Skip to content

Conversation

@MarcosNicolau
Copy link
Member

Description

Renames the batcher folder to crates and rename the workspace members folders to be more descriptive.

Type of change

  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

Copy link
Contributor

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths of example seems wrong, they have a ../batcher/sdk

Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batcher and CLI show these warning when starting

warning: /Users/juarce/repos/yetanothercompany/aligned_layer/crates/Cargo.toml: unused manifest key: workspace.edition
warning: /Users/juarce/repos/yetanothercompany/aligned_layer/crates/Cargo.toml: unused manifest key: workspace.name
warning: /Users/juarce/repos/yetanothercompany/aligned_layer/crates/Cargo.toml: unused manifest key: workspace.version

Besides that, it works as expected

@JuArce JuArce enabled auto-merge June 6, 2025 21:59
@JuArce JuArce added this pull request to the merge queue Jun 6, 2025
Merged via the queue into staging with commit 50c9c93 Jun 6, 2025
6 checks passed
@JuArce JuArce deleted the refactor/rust-crates branch June 6, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants