Refactor sdk modules #1941
Merged
Refactor sdk modules #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
JuArce
approved these changes
May 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SDK modules to simplify module indirection and improve overall structure by replacing imports from the core module with those from the new common module.
- Updated module import paths across multiple files from "crate::core" to "crate::common".
- Adjusted import ordering in some files to reflect the new structure.
- Minor reordering in batcher and aligned-batcher modules to support clearer separation of responsibilities.
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| batcher/aligned-sdk/src/eth/aligned_service_manager.rs | Updated error import path from core to common. |
| batcher/aligned-sdk/src/eth/aligned_proof_agg_service.rs | Updated error import path from core to common. |
| batcher/aligned-sdk/src/communication/protocol.rs | Updated error and type import paths from core to common. |
| batcher/aligned-sdk/src/communication/mod.rs | Added new communication module exports. |
| batcher/aligned-sdk/src/communication/messaging.rs | Replaced core type imports with common ones and reorganized import order. |
| batcher/aligned-sdk/src/communication/batch.rs | Updated import paths and module reference from core to common/verification_layer. |
| batcher/aligned-sdk/src/common/mod.rs | Introduces new common module structure for constants, errors, and types. |
| batcher/aligned-sdk/src/aggregation_layer.rs | Updated Network type import path from core to common. |
| batcher/aligned-batcher/src/zk_utils/mod.rs | Updated type import path for gnark-related verification data from core to common. |
| batcher/aligned-batcher/src/types/batch_queue.rs | Updated multiple import paths from core to common and reordered imports. |
| batcher/aligned-batcher/src/lib.rs | Updated constants and types import paths from core to common. |
| batcher/aligned-batcher/src/gnark/mod.rs | Adjusted ProvingSystemId import path from core to common. |
| batcher/aligned-batcher/src/eth/utils.rs | Updated constants import path from core to common. |
| batcher/aligned-batcher/src/connection.rs | Updated type import paths from core to common. |
| batcher/aligned-batcher/src/config/mod.rs | Updated constants import paths from core to common. |
| aggregation_mode/src/backend/s3.rs | Updated VerificationData type import from core to common. |
| aggregation_mode/src/backend/fetcher.rs | Updated ProvingSystemId type import from core to common. |
MarcosNicolau
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor sdk modules
Refactor SDK modules so they have less indirection and are more structured