Skip to content

Conversation

@MauroToscano
Copy link
Contributor

Add missing functions and events on agg contract

Description

Add missing function to set the Risc0 verifier address and events on agg contract

Type of change

Please delete options that are not relevant.

  • New feature

@github-actions
Copy link

github-actions bot commented May 12, 2025

Changes to gas cost

Generated at commit: de814f8a5cbddb1b1ff5dbe3ac3bb435d49e7b07, compared to commit: 837b4fbe4715d1b848b001bf77ce517608ae7d02

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask +48 ❌ +0.06%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,469,859 (+150,651) createNewTask
receive
57,794 (-48)
23,496 (0)
-0.08%
0.00%
77,845 (+48)
47,284 (+93)
+0.06%
+0.20%
77,934 (+12)
47,472 (0)
+0.02%
0.00%
78,804 (+12)
47,472 (0)
+0.02%
0.00%
256 (0)
256 (0)
StrategyManagerMock 2,401,360 (-12)
ProxyAdmin 757,634 (-12)
BLSApkRegistryHarness 3,124,225 (-12)

Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a picky comment, I would declare first errors, events and then functions. It is not related, but as we are changing it we can change the order here

@MauroToscano MauroToscano enabled auto-merge May 12, 2025 19:42
@MauroToscano MauroToscano added this pull request to the merge queue May 12, 2025
Merged via the queue into staging with commit 5607821 May 12, 2025
4 checks passed
@MauroToscano MauroToscano deleted the add_missing_functions_and_events_on_agg_contract branch May 12, 2025 19:58
@JuArce JuArce changed the title Add missing functions and events feat(aggregation_mode): add missing functions and events May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants