Skip to content

fix(aggregation_mode: update vk hash and image id #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 2 commits into from
May 9, 2025
Merged

fix(aggregation_mode: update vk hash and image id #1927

MauroToscano merged 2 commits into from
May 9, 2025

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented May 8, 2025 •
edited
Loading

Update vk hash and image id

Description

#1911 produced changes on programs, so vk_hash and image_id need to be updated

Closes #1926

How to Test

  1. Run anvil
make anvil_start
  1. Run batcher
make batcher_start_local
  1. Send some proofs
make batcher_send_risc0_burst BURST_SIZE=8
make batcher_send_so1_burst BURST_SIZE=8
  1. Run aggregation mode
make start_proof_aggregator AGGREGATOR=sp1
make start_proof_aggregator AGGREGATOR=risc0

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce linked an issue May 8, 2025 that may be closed by this pull request
fix(aggregation_mode): update vk_hash and image_id #1926
Closed
@JuArce JuArce self-assigned this May 8, 2025
@JuArce JuArce changed the base branch from testnet to staging May 8, 2025 22:36
@github-actions
Copy link

github-actions bot commented May 8, 2025 •
edited
Loading

Changes to gas cost

Generated at commit: cc9f8954779ec71781fbabe9f72a1684f137fd4c, compared to commit: 837b4fbe4715d1b848b001bf77ce517608ae7d02

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask -171 ✅ -0.22%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,469,871 (+150,663) createNewTask
receive		 57,794 (-48)
23,496 (0)		 -0.08%
0.00%		 77,626 (-171)
47,003 (-188)		 -0.22%
-0.40%		 77,958 (+36)
47,472 (0)		 +0.05%
0.00%		 78,705 (-87)
47,472 (0)		 -0.11%
0.00%		 256 (0)
256 (0)
TransparentUpgradeableProxy 897,987 (-12)

MarcosNicolau
MarcosNicolau approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me.

@MauroToscano MauroToscano added this pull request to the merge queue May 9, 2025
Merged via the queue into staging with commit fbc0b96 May 9, 2025
5 checks passed
@MauroToscano MauroToscano deleted the 1926-fixaggregation_mode-update-vk_hash-and-image_id branch May 9, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(aggregation_mode): update vk_hash and image_id

4 participants

@JuArce @MauroToscano @MarcosNicolau