Skip to content

fix(aggregation_mode): reset proof-aggregator.last_aggregated_block.json when starting start_proof_aggregator_dev #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 1 commit into from
May 6, 2025
Merged

fix(aggregation_mode): reset proof-aggregator.last_aggregated_block.json when starting start_proof_aggregator_dev #1920

MauroToscano merged 1 commit into from
May 6, 2025

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented May 6, 2025

Reset proof-aggregator.last_aggregated_block.json when starting start_proof_aggregator_dev

Description

It creates the file if it not exist and resets it to 0 befores running the aggregation mode

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this May 6, 2025
@JuArce JuArce linked an issue May 6, 2025 that may be closed by this pull request
fix(aggregation_mode): reset proof-aggregator.last_aggregated_block.json when starting start_proof_aggregator_dev #1919
Closed
@MauroToscano MauroToscano added this pull request to the merge queue May 6, 2025
Merged via the queue into staging with commit 252cb52 May 6, 2025
1 check passed
@MauroToscano MauroToscano deleted the 1919-fixaggregation_mode-reset-proof-aggregatorlast_aggregated_blockjson-when-starting-start_proof_aggregator_dev branch May 6, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(aggregation_mode): reset proof-aggregator.last_aggregated_block.json when starting start_proof_aggregator_dev

4 participants

@JuArce @MauroToscano @MarcosNicolau