Skip to content

feat(aggregation_mode): use deterministic build for SP1 #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 2 commits into from
May 6, 2025
Merged

feat(aggregation_mode): use deterministic build for SP1 #1916

MauroToscano merged 2 commits into from
May 6, 2025

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented May 5, 2025

Use deterministic build for SP1

Description

This PR adds deterministic build for SP1 aggregation mode

How to test

  1. Run anvil
make anvil_start
  1. Run aggregation mode
make start_proof_aggregator_dev AGGREGATOR=sp1
  1. Get the sp1_aggregator_program sha-512
shasum -a 512 aggregation_mode/aggregation_programs/sp1/elf/sp1_aggregator_program
  1. The output should be the following
c43c6203554e0776e4926afdf12c07507068fb1da12d5678b8ea32007e0601a1728c730f3cb6e194dbf359797265081cce57ecabfed09b6ec52c6b634e10b5ac  aggregation_mode/aggregation_programs/sp1/elf/sp1_aggregator_program

Type of change

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this May 5, 2025
MarcosNicolau
MarcosNicolau approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, tested it on Linux and macos.

@JuArce JuArce linked an issue May 6, 2025 that may be closed by this pull request
feat(aggregation_mode): use deterministic build for SP1 #1914
Closed
@JuArce JuArce changed the title feat: use deterministic build for SP1 feat(aggregation_mode): use deterministic build for SP1 May 6, 2025
@MauroToscano MauroToscano added this pull request to the merge queue May 6, 2025
Merged via the queue into staging with commit 83b1750 May 6, 2025
3 checks passed
@MauroToscano MauroToscano deleted the 1914-feataggregation_mode-use-deterministic-build branch May 6, 2025 19:36
@JuArce JuArce mentioned this pull request May 6, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(aggregation_mode): use deterministic build for SP1

4 participants

@JuArce @MauroToscano @MarcosNicolau