feat(aggregation_mode): verify aggregated proof on chain #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosNicolau
changed the base branch from
testnet
to
refactor/use-lambdaworks-merkle-tree
…agg-proof-on-chain
17 tasks
JuArce
changed the title
JuArce
requested changes
May 8, 2025
Collaborator
JuArce
left a comment
JuArce
left a comment
There was a problem hiding this comment.
There is missing updating the docs for the new functions
Also there is missing how to test this PR
# Conflicts: # aggregation_mode/programs_ids.json # contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
Member
Author
#1925 adds an example with a guide to test this! |
fix: add missing new line chore: update program ids
# Conflicts: # contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
MarcosNicolau
force-pushed
the
feat/verify-agg-proof-on-chain
branch
from
572609f to
fcb581a
Compare
# Conflicts: # batcher/aligned-sdk/src/sdk/aggregation.rs # contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
update ethereum package contracts add missing new line
JuArce
approved these changes
May 16, 2025
MarcosNicolau
force-pushed
the
feat/verify-agg-proof-on-chain
branch
from
2959292 to
4352e3b
Compare
JuArce
approved these changes
May 20, 2025
MauroToscano
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing functions for users to integrate an application with
AlignedProofAggregationService. This consists of:verifyProofInclusioninProofAggregationServicecontract was added. Given the proof program id, public inputs and the merkle proof, it constructs the merkle root and returns a boolean indicating if the aggregated proof exists or not.check_proof_verification: Given a proof, it queries the logs to find the proof, rebuilds the Merkle tree using the blob, and returns the Merkle path and root for the proof. This path is used as input for theverifyProofInclusionfunction in the contract.is_proof_verified_on_chain: Similar to whatis_proof_verifiedalready does but in this case it calls theverifyProofInclusionin the contract. This is mostly used for simulations and the former should be preferred.How to test it
To test it, you can do it via the example in #1925.
Type of change
Checklist
testnet, everything else tostaging