-
Notifications
You must be signed in to change notification settings - Fork 391
feat(aggregation_mode): aggregate proofs in chunks #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of a composite
…ith risc0 features" This reverts commit bd5ad9d.
ex proof_aggregator now is user_proots_aggregator and ex root_aggregator is now chunk_aggregator
MauroToscano
approved these changes
May 28, 2025
JuArce
reviewed
May 28, 2025
aggregation_mode/aggregation_programs/sp1/src/chunk_aggregator_main.rs
Outdated
Show resolved
Hide resolved
contracts/script/deploy/config/devnet/proof-aggregator-service.devnet.config.json
Show resolved
Hide resolved
JuArce
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split the aggregation of proofs in chunks. For this, the aggregation program had to be split in two:
Note: Because the root aggregator needs to verify that all input proofs were produced by the chunk aggregator, it must know the chunk aggregator’s program ID. This introduces a dependency between the two programs, requiring the root aggregator to be built after the chunk aggregator.
A script was created to automates this process. Running make
agg_mode_write_program_idsnow will:Considerations
Hash32type andMerkleTreeBackendis defined three times:We should consider having a
typescrates to share this kind of types. We can tackle this once we re-define the structure for the rust projects to have a single workspace with acratesfolder containing them all.How to test
MAX_PROOFS_PER_AGGREGATIONvariable to wait less):You should see via the logs the number of chunks to be processed. You can also inspect the gpu usage via
nvtop.Finally, once the aggregator finishes, you can verify that one of the proofs you sent has been aggregated via the aligned-cli and sdk:
Type of change
Checklist
testnet, everything else tostaging