Skip to content

fix(contracts): revert #1762 verifyBatchInclusion function #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 2 commits into from
Apr 28, 2025
Merged

fix(contracts): revert #1762 verifyBatchInclusion function #1892

MauroToscano merged 2 commits into from
Apr 28, 2025

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented Apr 25, 2025 •
edited by MauroToscano
Loading

Revert #1762 verifyBatchInclusion function

Description

This PR adds the old verifyBatchInclusion function. This is done to later remove the address from the params, since it's better to keep the address as a public input as to avoid someone downloading your proof and resubmitting it.

Closes #1891

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this Apr 25, 2025
@JuArce JuArce linked an issue Apr 25, 2025 that may be closed by this pull request
fix(contracts): revert #1762 verifyBatchInclusion function #1891
Closed
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

Changes to gas cost

Generated at commit: 33855de64e747395748573dfebf4f0ced71b1d23, compared to commit: b77e8fdf474834f0b9d018c28322b5c29512002e

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask
receive		 +233 ❌
+281 ❌		 +0.30%
+0.60%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,469,871 (+150,663) createNewTask
receive		 77,706 (+19,912)
47,472 (+23,976)		 +34.45%
+102.04%		 78,021 (+233)
47,472 (+281)		 +0.30%
+0.60%		 77,934 (-12)
47,472 (0)		 -0.02%
0.00%		 78,780 (+12)
47,472 (0)		 +0.02%
0.00%		 256 (0)
256 (0)

@MauroToscano
Copy link
Contributor

MauroToscano commented Apr 28, 2025

I though the previous one didn't use any address, if it works like this is not very useful, it's not compatible with the non address protocol

@MauroToscano MauroToscano reopened this Apr 28, 2025
@MauroToscano
Copy link
Contributor

MauroToscano commented Apr 28, 2025

Alright, since there is a special case with address 0, it's fine.

@MauroToscano MauroToscano merged commit 14f831f into testnet Apr 28, 2025
4 checks passed
@MauroToscano MauroToscano deleted the 1891-fixcontracts-revert-1762-verifybatchinclusion-function branch April 28, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(contracts): revert #1762 verifyBatchInclusion function

4 participants

@JuArce @MauroToscano @MarcosNicolau