Skip to content

feat(explorer): show aggregation mode componentes on testnet only #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 1 commit into from
Apr 28, 2025
Merged

feat(explorer): show aggregation mode componentes on testnet only #1890

MauroToscano merged 1 commit into from
Apr 28, 2025

Conversation

@MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Apr 24, 2025 •
edited by Mechanix97
Loading

Description

Adds a conditional rendering for aggregation mode components. If the ENVIRONMENT is set to mainnet then we don't render any of the aggregation-mode related components.

Type of change

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau MarcosNicolau changed the base branch from testnet to staging April 24, 2025 20:39
@github-actions
Copy link

github-actions bot commented Apr 24, 2025

Changes to gas cost

Generated at commit: 0b89259daace00e0915ed8c90cbc6b6922b343cf, compared to commit: b77e8fdf474834f0b9d018c28322b5c29512002e

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask +67 ❌ +0.09%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,319,208 (0) createNewTask
receive		 57,806 (+12)
23,496 (0)		 +0.02%
0.00%		 77,855 (+67)
47,284 (+93)		 +0.09%
+0.20%		 77,946 (0)
47,472 (0)		 0.00%
0.00%		 78,729 (-39)
47,472 (0)		 -0.05%
0.00%		 256 (0)
256 (0)
BLSApkRegistryHarness 3,124,225 (-12)

JuArce
JuArce approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MauroToscano MauroToscano added this pull request to the merge queue Apr 28, 2025
Merged via the queue into staging with commit d5235ed Apr 28, 2025
8 checks passed
@MauroToscano MauroToscano deleted the explorer-agg-mode-for-testnet-only branch April 28, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

Assignees

@MarcosNicolau MarcosNicolau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcosNicolau @MauroToscano @JuArce