Skip to content

feat: proof aggregator upgrade scripts #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuArce merged 8 commits into from
Apr 25, 2025
Merged

feat: proof aggregator upgrade scripts #1888

JuArce merged 8 commits into from
Apr 25, 2025

Conversation

@MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Apr 23, 2025

Description

Upgrade script for ProofAggregatorService contract.

Type of change

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau MarcosNicolau marked this pull request as ready for review April 23, 2025 14:25
@github-actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

Changes to gas cost

Generated at commit: da9b11ad900b3975c81d18c4383dbd7b110cc8cc, compared to commit: 837b4fbe4715d1b848b001bf77ce517608ae7d02

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask
receive		 +232 ❌
+281 ❌		 +0.30%
+0.60%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,319,208 (0) createNewTask
receive		 77,718 (+19,876)
47,472 (+23,976)		 +34.36%
+102.04%		 78,029 (+232)
47,472 (+281)		 +0.30%
+0.60%		 77,958 (+36)
47,472 (0)		 +0.05%
0.00%		 78,705 (-87)
47,472 (0)		 -0.11%
0.00%		 256 (0)
256 (0)
BLSApkRegistryHarness 3,124,225 (-12)

@MarcosNicolau MarcosNicolau mentioned this pull request Apr 23, 2025
Merged
14 tasks
JuArce
JuArce requested changes Apr 23, 2025
View reviewed changes
@MarcosNicolau MarcosNicolau requested a review from JuArce April 23, 2025 21:40
JuArce
JuArce requested changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing the makefile target

@MarcosNicolau
Copy link
Member Author

MarcosNicolau commented Apr 24, 2025

There is missing the makefile target
@JuArce, I've added it in d8a5d24.

@MarcosNicolau MarcosNicolau requested a review from JuArce April 24, 2025 18:52
@JuArce JuArce added this pull request to the merge queue Apr 25, 2025
Merged via the queue into staging with commit 83576e3 Apr 25, 2025
3 checks passed
@JuArce JuArce deleted the feat/proof-aggregator-upgrade-scripts branch April 25, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcosNicolau @MauroToscano @JuArce