feat(aggregation_mode): save last processed block in a file #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mechanix97
changed the title
JuArce
changed the title
…-in-a-file' of github.com:yetanotherco/aligned_layer into 1870-refactoraggregation_mode-save-last-processed-block-in-a-file
JuArce
approved these changes
Apr 14, 2025
Collaborator
JuArce
left a comment
JuArce
left a comment
There was a problem hiding this comment.
lgtm
- It creates the file if it does not exist ✅
- It updates the file only if the verification was correctly sent to ethereum ✅
- It use the current block when the events were fetched and not when the process finishes, which is correct ✅
.gitignore
Outdated
| **/broadcast | ||
| volume | ||
| config-files/*.last_processed_batch.json | ||
| config-files/*.last_processed_block.json |
Contributor
There was a problem hiding this comment.
Change this to last_aggregated_block.json, or the folder/name to reflect this is for aggregation
| fetch_logs_from_secs_ago: 86400 # 24hs | ||
| # Anvil start with block time is 7 seconds | ||
| block_time_secs: 7 | ||
| last_processed_block_filepath: config-files/proof-aggregator.last_processed_block.json |
Contributor
There was a problem hiding this comment.
Idem the other suggestion
JuArce
reviewed
Apr 15, 2025
JuArce
reviewed
Apr 15, 2025
JuArce
reviewed
Apr 15, 2025
Collaborator
JuArce
left a comment
JuArce
left a comment
There was a problem hiding this comment.
Lgtm but this structure could be removed to avoid an extra level of indirection
#[derive(Debug, Deserialize, Serialize)]
pub struct LastAggregatedBlock {
pub last_aggregated_block: u64,
}
MauroToscano
approved these changes
Apr 15, 2025
JuArce
deleted the
1870-refactoraggregation_mode-save-last-processed-block-in-a-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat (aggregation mode) save last processed block in a file
Description
From Issue #1870
Save the last processed block in a json file which path is indicated in the argument config file.
Check if the last_processed_block is lower than the current block of the chain.
Add a method to the config to save the current last_processed_block (discarding the previous file)
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging