Skip to content

Conversation

@MarcosNicolau
Copy link
Member

Description

Various refactors for the aggregation:

  • Updated error enums to include descriptive error messages.
  • Renamed sp1_aggregator structs to use more explicit and descriptive names that better reflect their purpose and contents.
  • Updated the hash implementation in the to use sp1 built-in hash_bytes function. This eliminates the conversion from u32 to u8. This required us to update the hash in the sp1_aggregator program to convert u32 to u8 in big endian instead of little endian. This change is especially useful for sdk users, as it abstracts away internal details of the vk hashing, which they have to provide when trying to verify proof inclusion in agg mode.

Type of change

  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau MarcosNicolau mentioned this pull request Apr 14, 2025
14 tasks
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MauroToscano MauroToscano enabled auto-merge April 14, 2025 18:55
@MauroToscano MauroToscano added this pull request to the merge queue Apr 14, 2025
Merged via the queue into staging with commit 9e70085 Apr 14, 2025
3 checks passed
@MauroToscano MauroToscano deleted the refactor/agg-mode branch April 14, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants