Skip to content

feat: bump gnark version to 0.12 #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 8 commits into from
Jun 4, 2025
Merged

feat: bump gnark version to 0.12 #1863

MauroToscano merged 8 commits into from
Jun 4, 2025

Conversation

@Mechanix97
Copy link
Contributor

@Mechanix97 Mechanix97 commented Apr 10, 2025 •
edited by JuArce
Loading

Bump gnark version from 0.10 to 0.12

Description

Update the version in go.mod and go.sum.
Update the test files of groth16 to make it work (plonk 0.10 test files still works).
fix the CI to use the correct test files.
Update the docs.

How to Test

  1. Run anvil
make anvil_start
  1. You may need to run cargo clean
cd batcher/aligned-batcher
cargo clean
cd ../..
  1. Run batcher
make batcher_start_local
  1. Run aggregator
make aggregator_start ENVIRONMENT=devnet
  1. Run operators
make operator_full_registration CONFIG_FILE=config-files/config-operator-1.yaml ENVIRONMENT=devnet
make operator_start CONFIG_FILE=config-files/config-operator-1.yaml ENVIRONMENT=devnet
  1. Install aligned cli
make install_aligned_compiling
  1. Send proofs

Using docs commands (I changed the parameters to use devnet, but proofs paths are the same)

aligned submit \
--proving_system GnarkPlonkBn254 \
--proof ./scripts/test_files/gnark_plonk_bn254_script/plonk_0_12_0.proof \
--public_input ./scripts/test_files/gnark_plonk_bn254_script/plonk_pub_input_0_12_0.pub \
--vk ./scripts/test_files/gnark_plonk_bn254_script/plonk_0_12_0.vk \
--network devnet \
--rpc_url http://localhost:8545 \
--repetitions 4

aligned submit \
--proving_system GnarkPlonkBls12_381 \
--proof ./scripts/test_files/gnark_plonk_bls12_381_script/plonk_0_12_0.proof \
--public_input ./scripts/test_files/gnark_plonk_bls12_381_script/plonk_pub_input_0_12_0.pub \
--vk ./scripts/test_files/gnark_plonk_bls12_381_script/plonk_0_12_0.vk \
--network devnet \
--rpc_url http://localhost:8545 \
--repetitions 4

aligned submit \
--proving_system Groth16Bn254 \
--proof ./scripts/test_files/gnark_groth16_bn254_script/groth16.proof \
--public_input ./scripts/test_files/gnark_groth16_bn254_script/groth16.pub \
--vk ./scripts/test_files/gnark_groth16_bn254_script/groth16.vk \
--network devnet \
--rpc_url http://localhost:8545 \
--repetitions 4

Using makefile commands

make batcher_send_plonk_bn254_task

make batcher_send_plonk_bn254_burst

make batcher_send_plonk_bls12_381_task

make batcher_send_plonk_bls12_381_burst

make batcher_send_groth16_bn254_task

Note: You can also test it with ethereum-package

Type of change

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@Mechanix97 Mechanix97 changed the title Feat/bump gnark version to 0 12 Feat/bump gnark version to 0.12 Apr 10, 2025
@Mechanix97 Mechanix97 marked this pull request as ready for review April 11, 2025 20:58
@JuArce JuArce changed the base branch from testnet to staging April 14, 2025 19:01
@JuArce JuArce changed the title Feat/bump gnark version to 0.12 feat: bump gnark version to 0.12 May 8, 2025
@JuArce JuArce mentioned this pull request May 23, 2025
Open
JuArce
JuArce requested changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test proof should have the version in the name. I will fix it

MarcosNicolau
MarcosNicolau approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me locally on ethereum package.

scripts/test_files/README.md
Copy link
Member

@MarcosNicolau MarcosNicolau May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, should we open a new pr with the instruction for SP1 and Risc0?

@JuArce JuArce self-assigned this May 28, 2025
@MauroToscano MauroToscano self-requested a review May 29, 2025 18:33
JuArce
JuArce requested changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge for v0.16.0

@MauroToscano MauroToscano added this pull request to the merge queue Jun 4, 2025
Merged via the queue into staging with commit 72583d9 Jun 4, 2025
3 checks passed
@MauroToscano MauroToscano deleted the feat/bump-gnark-version-to-0-12 branch June 4, 2025 14:52
@JuArce JuArce mentioned this pull request Jun 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mechanix97 @MauroToscano @JuArce @MarcosNicolau