Skip to content

perf: aggregation-mode sp1 prover setup #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 1 commit into from
Apr 10, 2025
Merged

perf: aggregation-mode sp1 prover setup #1862

MauroToscano merged 1 commit into from
Apr 10, 2025

Conversation

@MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Apr 9, 2025

Description

Use LazyLock to setup the sp1 prover client. This avoids recreating the prover for every usage which we noticed has a big overhead.

Type of change

  • Optimization

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau
fix: use lazy lock to setup prover
63860c0 
this avoids recreating the prover for every usage which has quite the overhead
@MarcosNicolau MarcosNicolau changed the title fix: agg mode sp1 build fix: aggregation-mode sp1 prover setup Apr 9, 2025
@MarcosNicolau MarcosNicolau changed the title fix: aggregation-mode sp1 prover setup perf: aggregation-mode sp1 prover setup Apr 9, 2025
@MauroToscano MauroToscano added this pull request to the merge queue Apr 10, 2025
Merged via the queue into staging with commit ca2bc86 Apr 10, 2025
3 checks passed
@MauroToscano MauroToscano deleted the fix/agg-mode-sp1-build branch April 10, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcosNicolau @MauroToscano @JuArce