feat: aggregation mode sdk #1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way we users don't need to know the internals of the agg_mode proof commitment which is still unstable
MauroToscano
approved these changes
Apr 14, 2025
Contributor
MauroToscano
left a comment
MauroToscano
left a comment
There was a problem hiding this comment.
@JuArce needs to test it, but it looks good
JuArce
reviewed
Apr 15, 2025
| }; | ||
|
|
||
| let Some(beacon_block) = beacon_client | ||
| .get_block_header_from_parent_hash(beacon_parent_root.0) |
Collaborator
There was a problem hiding this comment.
Isn't a way to avoid using indexes?
Member
Author
There was a problem hiding this comment.
What do you mean by indexes? If you mean the beacon_parent_root.0, that is not an index but a way to get the value that ethers library is wrapping.
| - Mainnet: `https://ethereum-rpc.publicnode.com` | ||
| - Holesky: `https://ethereum-holesky-rpc.publicnode.com` | ||
| - Also, you can use your own Ethereum RPC providers. | ||
| - `--beacon_client_url <BEACON_CLIENT_URL>`: User's Ethereum Consensus provider connection address. Public nodes don't support this method. |
Collaborator
There was a problem hiding this comment.
If it is possible, I'd add a free beacon client
Member
Author
There was a problem hiding this comment.
Free beacon client don't support retrieve the blob data. Should I still add one?
JuArce
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aggregation mode sdk method to verify if proof has been verified by the ProofAggregationService.
Note: this should be merged after #1871
How to run it
cdinto sdk project:cd batcher/alignedcargo run verify-agg-proof --network <NETWORK> --from-block <FROM_BLOCK> --proving_system SP1 --vk <VK_HASH_FILEPATH> --public_input <PUBLIC_INPUTS_FILEPATH> --beacon_url <BEACON_NODE_URL> --rpc_url <RPC_URL>For example:
Notes:
--from-blockis an optional params, if not provided it will fetch the logs from the past 24hs.Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging