Skip to content

Checks functions refactor #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 2 commits into from
Apr 11, 2025
Merged

Checks functions refactor #1860

MauroToscano merged 2 commits into from
Apr 11, 2025

Conversation

@MauroToscano
Copy link
Contributor

@MauroToscano MauroToscano commented Apr 9, 2025 •
edited
Loading

Checks functions

  • Refactors all checks when receiving tasks from users, before starting to use locks into it's own functions
  • Change the logic of checking max size of the verification data to get the whole size, and not only the proof

Type of change

  • Refactor
  • BugFix

@MauroToscano MauroToscano changed the base branch from testnet to staging April 9, 2025 19:05
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Changes to gas cost

Generated at commit: f0838d4aa75b12279310dc64ea1361bdc5ae2002, compared to commit: d9fd29dba06f745523129cb9b751ab62b8abcfc4

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask
receive		 +216 ❌
+281 ❌		 +0.28%
+0.60%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,319,208 (0) createNewTask
receive		 77,706 (+19,900)
47,472 (+23,976)		 +34.43%
+102.04%		 78,022 (+216)
47,472 (+281)		 +0.28%
+0.60%		 77,910 (-48)
47,472 (0)		 -0.06%
0.00%		 78,816 (+75)
47,472 (0)		 +0.10%
0.00%		 256 (0)
256 (0)

MarcosNicolau
MarcosNicolau approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it is noticeably more readable now 👍

@MauroToscano MauroToscano added this pull request to the merge queue Apr 11, 2025
Merged via the queue into staging with commit b63a928 Apr 11, 2025
3 checks passed
@MauroToscano MauroToscano deleted the checks_functions branch April 11, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MauroToscano @JuArce @MarcosNicolau