-
Notifications
You must be signed in to change notification settings - Fork 391
feat: aggregation mode explorer #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
explorer/lib/explorer/contract_managers/aligned_proof_aggregation_service.ex
Outdated
Show resolved
Hide resolved
this prevents the situation where we would increase by one the slot from the parent but no block was proposed in the next slot
| nil -> | ||
| Explorer.Repo.insert(changeset) | ||
|
|
||
| existing_proof -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it is more a general problem in the explorer, but in some moment we should improve logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we should improve the logs + add a ci for formatting.
explorer/priv/repo/migrations/20250407002009_create_aggregated_proofs.exs
Outdated
Show resolved
Hide resolved
JuArce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most important change is related to the db scheme
Description
Adds periodic fetches for aggregation mode events and stores data structures in db.
How to run
make explorer_build_dbmake explorer_run_dbmake explorer_ecto_setup_dbmake run_explorerpsql:docker exec -it explorer-postgres-container psql -U explorer_user -d explorer_dbSELECT * FROM aggregated_proofs;SELECT * FROM proofs_agg_mode WHERE aggregated_proof_number = NType of change
Checklist
testnet, everything else tostaging