-
Notifications
You must be signed in to change notification settings - Fork 391
feat: integrate sp1 verifier with aggregation mode #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 26 changed files in this pull request and generated 1 comment.
Files not reviewed (18)
- Makefile: Language not supported
- contracts/deployments/31337.json: Language not supported
- contracts/lib/sp1-contracts: Language not supported
- contracts/remappings.txt: Language not supported
- contracts/script/deploy/SP1VerifierGatewayGroth16Deployer.s.sol: Language not supported
- contracts/script/deploy/SP1VerifierGroth16Deployer.s.sol: Language not supported
- contracts/script/deploy/config/devnet/proof-aggregator-service.devnet.config.json: Language not supported
- contracts/script/deploy/config/devnet/proof-aggregator-service.devnet.mock.config.json: Language not supported
- contracts/script/deploy/config/holesky/proof-aggregator-service.holesky.config.stage.json: Language not supported
- contracts/script/output/devnet/alignedlayer_deployment_output.json: Language not supported
- contracts/script/output/devnet/proof_aggregation_service_deployment_output.mock.json: Language not supported
- contracts/script/output/holesky/proof_aggregation_service_deployment_output.stage.json: Language not supported
- contracts/scripts/.env.stage: Language not supported
- contracts/scripts/anvil/deploy_aligned_contracts.sh: Language not supported
- contracts/scripts/anvil/deploy_sp1_contracts.sh: Language not supported
- contracts/scripts/deploy_proof_aggregator.sh: Language not supported
- contracts/scripts/proof_aggregator_service/.env.example: Language not supported
- contracts/scripts/proof_aggregator_service/deploy.sh: Language not supported
…to-aggregation-mode # Conflicts: # Makefile
…-mode # Conflicts: # Makefile # contracts/script/deploy/config/devnet/proof-aggregator-service.devnet.config.json # contracts/scripts/anvil/deploy_aligned_contracts.sh # contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json # contracts/src/core/AlignedProofAggregationService.sol # contracts/src/core/IAlignedProofAggregationService.sol
MarcosNicolau
approved these changes
Apr 7, 2025
MauroToscano
approved these changes
Apr 8, 2025
chore: update abi.json
MarcosNicolau
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate sp1 verifier with aggregation mode
Description
Deploys SP1 contracts on anvil in devnet.
Creates a new Makefile command to deploy the sp1 verification contracts and gateways
To ensure the correct state load on anvil, the deployer first loads the eigenlayers contracts and then dumps them into the sp1-contracts state file with the sp1 contracts already loaded. Then, the anvil aligned contracts deployer (make anvil_deploy_aligned_contracts) loads this state on start instead of the original eigenlayer contracts.
How to test
make anvil_start_with_block_timemake batcher_start_localmake batcher_send_sp1_burstOnce the batch is created, you can run the proof aggregator with
make start_proof_aggregator_local_with_provingIf you want to run the verifier with a mock, run
make start_proof_aggregator_localNote: Step 4 will take some time because it has to aggregate the proofs
Type of change
Checklist