Pull changes from tesnet #1825
Merged
Pull changes from tesnet #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… python scripts on `examples/verify` (#1796) Co-authored-by: Mauro Toscano <[email protected]>
Co-authored-by: MauroFab <[email protected]>
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the verification scripts to include support for an additional parameter—the sender address—when encoding and verifying batch inclusion proofs. The changes extend the CLI commands, update the output encoding to include the sender address, and adjust the example commands in the README.
- Updated the CLI argument parsing in both verify.py and encode_verification_data.py to include --sender-address.
- Modified the encode_call function to accept a sender_address parameter and adjusted the encoding scheme accordingly.
- Revised the README to reflect the new usage and example commands.
Reviewed Changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/verify/verify.py | Added --sender-address argument and updated encode_call call |
| examples/verify/encode_verification_data.py | Updated encode_call signature and encoding scheme with sender_address |
| examples/verify/README.md | Updated CLI commands and example JSON output sample to include sender-address |
Files not reviewed (5)
- contracts/script/deploy/config/mainnet_staging/aligned.mainnet.config.json: Language not supported
- contracts/script/deploy/config/mainnet_staging/batcher-payment-service.mainnet.config.json: Language not supported
- contracts/script/output/mainnet_staging/alignedlayer_deployment_output.json: Language not supported
- contracts/scripts/.env.mainnet.staging: Language not supported
- examples/verify/src/VerifyBatchInclusionCaller.sol: Language not supported
Comments suppressed due to low confidence (2)
examples/verify/verify.py:13
- [nitpick] Consider marking the '--sender-address' argument as required (e.g., by adding required=True) to prevent potential runtime errors when the argument is omitted.
parser.add_argument('--sender-address', help='Address that sent the batch to Aligned')
examples/verify/encode_verification_data.py:33
- [nitpick] Consider marking '--sender-address' as required to ensure the script is executed with all necessary parameters.
parser.add_argument('--sender-address', help='Address that sent the batch to Aligned')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Description of the pull request changes and motivation.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging