-
Notifications
You must be signed in to change notification settings - Fork 391
v0.15.0 #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.15.0 #1814
Conversation
…ed (#1694) Co-authored-by: Julian Ventura <[email protected]>
Co-authored-by: Julian Ventura <[email protected]>
Co-authored-by: Uriel Mihura <[email protected]>
Co-authored-by: Urix <[email protected]> Co-authored-by: JuArce <[email protected]>
Co-authored-by: PatStiles <[email protected]> Co-authored-by: avilagaston9 <[email protected]>
Co-authored-by: Urix <[email protected]> Co-authored-by: Marcos Nicolau <[email protected]> Co-authored-by: PatStiles <[email protected]> Co-authored-by: Avila Gastón <[email protected]> Co-authored-by: Marcos Nicolau <[email protected]> Co-authored-by: nicolau <[email protected]>
Co-authored-by: Marcos Nicolau <[email protected]> Co-authored-by: Mauro Toscano <[email protected]> Co-authored-by: Urix <[email protected]> Co-authored-by: MauroFab <[email protected]> Co-authored-by: JuArce <[email protected]>
… not been spent (#1725) Co-authored-by: Uriel Mihura <[email protected]>
Co-authored-by: Urix <[email protected]>
Co-authored-by: Tomás Casagrande <[email protected]> Co-authored-by: JuArce <[email protected]>
…fixes_testnet_17_01 # Conflicts: # explorer/.env.dev # explorer/.env.example # explorer/lib/explorer_web/live/utils.ex # explorer/start.sh
) Co-authored-by: Urix <[email protected]> Co-authored-by: JuArce <[email protected]>
Co-authored-by: Urix <[email protected]> Co-authored-by: JuArce <[email protected]>
…li commands (#1553) Co-authored-by: Marcos Nicolau <[email protected]> Co-authored-by: Urix <[email protected]> Co-authored-by: JuArce <[email protected]>
# Conflicts: # alerts/sender_with_alert.sh # explorer/.env.dev # explorer/.env.example
Co-authored-by: JuArce <[email protected]>
Co-authored-by: Mario Rugiero <[email protected]> Co-authored-by: Julian Arce <[email protected]>
Co-authored-by: JuArce <[email protected]> Co-authored-by: MauroFab <[email protected]>
…erServiceManager.sol (#1762) Co-authored-by: JuArce <[email protected]>
Co-authored-by: JuArce <[email protected]>
Co-authored-by: Klaus Lungwitz <[email protected]> Co-authored-by: Julian Arce <[email protected]>
…e.sol (#1772) Co-authored-by: JuArce <[email protected]> Co-authored-by: MauroFab <[email protected]>
…1770) Co-authored-by: MauroFab <[email protected]>
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Co-authored-by: JuArce <[email protected]>
Co-authored-by: JuArce <[email protected]>
Co-authored-by: Mauro Toscano <[email protected]> Co-authored-by: MauroFab <[email protected]>
# Conflicts: # batcher/aligned-sdk/src/core/types.rs # batcher/aligned-sdk/src/sdk.rs # batcher/aligned/src/main.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR (v0.15.0) introduces several improvements and refactorings across the SDK and batcher modules. Key changes include:
- Changes to fee estimation logic and renaming of related functions and types.
- Refactoring network handling to use methods on the Network enum rather than passing explicit URLs.
- Enhancements to error messages and new metrics for queue tracking in the batcher.
Reviewed Changes
Copilot reviewed 188 out of 195 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| batcher/aligned-task-sender/README.md | Updated the CLI usage example to reflect the new network parameter instead of a hardcoded URL. |
| batcher/aligned-sdk/src/sdk.rs | Refactored fee estimation functions and updated documentation with new fee estimation types. |
| batcher/aligned-sdk/src/core/types.rs | Renamed PriceEstimate to FeeEstimationType and added a Custom option in the Network API. |
| batcher/aligned-sdk/src/core/errors.rs | Replaced MaxFeeEstimateError with FeeEstimateError across the SDK to reflect the new logic. |
| batcher/aligned-sdk/src/core/constants.rs | Updated fee estimation constants and added network address constants for the batcher. |
| batcher/aligned-sdk/src/communication/messaging.rs | Enriched error messages to include additional context on transaction fund handling. |
| batcher/aligned-sdk/src/communication/batch.rs | Small refactor to pass a cloned network in the proof verification loop. |
| batcher/aligned-batcher/src/sp1/mod.rs | Updated initialization of sp1-sdk components to use environment-based configuration. |
| batcher/aligned-batcher/src/metrics.rs | Added new metrics for tracking the queue length and queue size (bytes). |
| batcher/aligned-batcher/src/main.rs | Added a new CLI argument for address configuration and updated variable naming accordingly. |
| batcher/aligned-batcher/src/lib.rs | Integrated queue metric updates at critical points in the batch processing logic. |
| batcher/aligned-batcher/Cargo.toml | Upgraded sp1-sdk dependency to the latest version. |
| .github/workflows/build-and-test-go.yml | Removed outdated build steps and adjusted workflow steps to match the current project structure. |
Files not reviewed (7)
- .github/workflows/test-risc-zero-old.yml: Language not supported
- .github/workflows/test-sp1-old.yml: Language not supported
- Makefile: Language not supported
- alerts/.env.devnet: Language not supported
- alerts/.env.example: Language not supported
- alerts/sender_with_alert.sh: Language not supported
- batcher/aligned-batcher/rust-toolchain: Language not supported
Comments suppressed due to low confidence (1)
batcher/aligned-batcher/src/main.rs:27
- [nitpick] The CLI parameter is named 'addr' while later in the code it is reformatted as 'address'. Consider renaming 'addr' to 'address' in the CLI definition for consistent naming.
#[arg(short, long)]
Co-authored-by: Julian Arce <[email protected]>
v0.15.0
Description