Skip to content

refactor(contract): change checkPublicInput to external in AlignedServiceManager #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 3 commits into from
Mar 19, 2025
Merged

refactor(contract): change checkPublicInput to external in AlignedServiceManager #1792

MauroToscano merged 3 commits into from
Mar 19, 2025

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented Feb 10, 2025

Change checkPublicInput to external in AlignedServiceManager

Description

checkPublicInput function can be declared as external instead of public.

This change reduces the cost of calling it.

Type of change

  • Optimization

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this Feb 10, 2025
@github-actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

Changes to gas cost

Generated at commit: e747defec9f51434d8317d1cf1939a4c8daa4539, compared to commit: 677f9a9a4895b44c7ff12d7b950a93768a7ae9e0

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask -28 ✅ -0.04%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,319,208 (0) createNewTask 57,806 (-60) -0.10% 77,691 (-28) -0.04% 77,898 (-84) -0.11% 78,768 (+27) +0.03% 256 (0)

@JuArce JuArce linked an issue Feb 11, 2025 that may be closed by this pull request
refactor(contract): change checkPublicInput to external in AlignedServiceManager #1791
Closed
JuArce added 2 commits March 19, 2025 16:20
@JuArce
Merge branch 'refs/heads/staging' into 1791-refactorcontract-change-c…
49e7fb7 
…heckpublicinput-to-external-in-alignedservicemanager

# Conflicts:
#	contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
#	contracts/src/core/IAlignedLayerServiceManager.sol
@JuArce
chore: update anvil state
6faff4c
@MauroToscano MauroToscano enabled auto-merge March 19, 2025 19:30
@MauroToscano MauroToscano added this pull request to the merge queue Mar 19, 2025
Merged via the queue into staging with commit 7038413 Mar 19, 2025
4 checks passed
@MauroToscano MauroToscano deleted the 1791-refactorcontract-change-checkpublicinput-to-external-in-alignedservicemanager branch March 19, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor(contract): change checkPublicInput to external in AlignedServiceManager

3 participants

@JuArce @MauroToscano