Skip to content

fix(CI): update foundry-gas-diff to version v3.21 #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 1 commit into from
Feb 10, 2025
Merged

fix(CI): update foundry-gas-diff to version v3.21 #1789

MauroToscano merged 1 commit into from
Feb 10, 2025

Conversation

@JuArce
Copy link
Collaborator

@JuArce JuArce commented Feb 10, 2025

Update foundry-gas-diff to version v3.21

Description

Gas diff report is failing with the following error

Error: Create Artifact Container failed: The artifact name 1761-featcontract-add-amount_of_proofs-in-taskcreated-event.gasreport.ansi is not valid. Request URL https://pipelinesghubeus13.actions.githubusercontent.com/cYZQXBGeY5K3sV7lEtZpwKQOeeiQYOSUI5jrVEEF3mjEO5MAA5/_apis/pipelines/workflows/13208738459/artifacts?api-version=6.0-preview

Updating from version v3.16 to v3.21 fixes the error

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce self-assigned this Feb 10, 2025
@JuArce JuArce linked an issue Feb 10, 2025 that may be closed by this pull request
fix(CI): update foundry-gas-diff to version v3.21 #1788
Closed
@github-actions
Copy link

github-actions bot commented Feb 10, 2025

Changes to gas cost

Generated at commit: 8f6b2329f44a0946fde34e1db7bbb015fb32ffa8, compared to commit: 399c50c669a0d7a9e1e3b0350aca6abee637c6ac

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
RegistryCoordinatorHarness blsApkRegistry +332 ❌ +116.90%
Slasher initialize +470 ❌ +103.98%
StakeRegistryHarness delegation +332 ❌ +101.84%
AlignedLayerServiceManager batchesState +688 ❌ +95.29%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
RegistryCoordinatorHarness 10,130,048 (+4,267,886) blsApkRegistry
initialize
stakeRegistry		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 6 (0)
6 (0)
6 (0)
Slasher 1,598,813 (+762,834) initialize 922 (+470) +103.98% 922 (+470) +103.98% 922 (+470) +103.98% 922 (+470) +103.98% 6 (0)
StakeRegistryHarness 5,139,510 (+2,005,517) delegation
initializeQuorum		 658 (+332)
146,200 (+3,117)		 +101.84%
+2.18%		 658 (+332)
165,996 (+3,117)		 +101.84%
+1.91%		 658 (+332)
166,100 (+3,117)		 +101.84%
+1.91%		 658 (+332)
166,100 (+3,117)		 +101.84%
+1.91%		 6 (0)
1,152 (0)
AlignedLayerServiceManager 8,615,423 (+3,384,189) batchesState
createNewTask
disableVerifier
disabledVerifiers
enableVerifier
isVerifierDisabled
receive
setDisabledVerifiers		 1,410 (+688)
58,349 (+2,242)
24,299 (+390)
514 (+131)
24,191 (+390)
856 (+275)
23,496 (+179)
24,250 (+451)		 +95.29%
+4.00%
+1.63%
+34.20%
+1.64%
+47.33%
+0.77%
+1.90%		 1,410 (+688)
77,939 (+1,867)
35,816 (+315)
514 (+131)
24,760 (+315)
1,522 (+275)
47,378 (+463)
35,176 (+370)		 +95.29%
+2.45%
+0.89%
+34.20%
+1.29%
+22.05%
+0.99%
+1.06%		 1,410 (+688)
77,952 (+1,705)
35,816 (+315)
514 (+131)
24,760 (+315)
856 (+275)
47,472 (+277)
35,176 (+370)		 +95.29%
+2.24%
+0.89%
+34.20%
+1.29%
+47.33%
+0.59%
+1.06%		 1,410 (+688)
78,741 (+1,612)
47,334 (+240)
514 (+131)
25,329 (+240)
2,856 (+275)
47,472 (+277)
46,103 (+290)		 +95.29%
+2.09%
+0.51%
+34.20%
+0.96%
+10.65%
+0.59%
+0.63%		 256 (0)
256 (0)
2 (0)
1 (0)
2 (0)
3 (0)
256 (0)
2 (0)
ProxyAdmin 757,646 (+329,348) upgrade
upgradeAndCall		 39,641 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,650 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,653 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,653 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 24 (0)
6 (0)
AVSDirectory 3,174,782 (+1,463,543) initialize 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 6 (0)
ServiceManagerMock 2,632,771 (+1,054,449) initialize 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 6 (0)
BLSApkRegistryHarness 3,124,237 (+1,317,862) initializeQuorum
setBLSPublicKey		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 1,152 (0)
6 (0)
TransparentUpgradeableProxy 897,999 (+341,241) fallback 1,544 (+477) +44.70% 48,066 (+774) +1.64% 8,110 (+477) +6.25% 120,000 (+885) +0.74% 30 (0)
IndexRegistry 1,707,545 (+637,897) initializeQuorum 45,592 (+528) +1.17% 45,592 (+528) +1.17% 45,592 (+528) +1.17% 45,592 (+528) +1.17% 1,152 (0)
StrategyManagerMock 2,401,372 (+1,154,891) setAddresses 89,742 (+597) +0.67% 89,742 (+597) +0.67% 89,742 (+597) +0.67% 89,742 (+597) +0.67% 6 (0)

@MauroToscano MauroToscano merged commit 5b582d0 into testnet Feb 10, 2025
2 checks passed
@MauroToscano MauroToscano deleted the 1788-fixci-update-foundry-gas-diff-to-version-v321 branch February 10, 2025 16:06
MauroToscano added a commit that referenced this pull request Feb 10, 2025
@MauroToscano
fix(CI): update foundry-gas-diff to version v3.21 (#1789) (#1790)
f009da5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

Assignees

@JuArce JuArce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(CI): update foundry-gas-diff to version v3.21

3 participants

@JuArce @MauroToscano