Skip to content

fix(contract): remove reinitializers from AlignedLayerServiceManager #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 9 commits into from
Mar 19, 2025
Merged

fix(contract): remove reinitializers from AlignedLayerServiceManager #1770

MauroToscano merged 9 commits into from
Mar 19, 2025

Conversation

@uri-99
Copy link
Contributor

@uri-99 uri-99 commented Jan 20, 2025

Remove reinitializers from AlignedLayerServiceManager

Description

Reinitializers are being used in testnet but where not executed in mainnet. They should be removed with a proper comment

Important

This PR requires a mainnet redeploy, to disable the un-executed reinitializers

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 linked an issue Jan 20, 2025 that may be closed by this pull request
fix(contract): remove reinitializers from contracts #1759
Closed
@uri-99 uri-99 changed the base branch from testnet to staging January 20, 2025 20:53
@MauroToscano
Add comment
f4b79ff
@MauroToscano
Merge branch '1759-fixcontract-remove-reinitializers-from-contracts' …
8ae23f4 
…of github.com:yetanotherco/aligned_layer into 1759-fixcontract-remove-reinitializers-from-contracts
@MauroToscano
Add comment
ff6744a
@MauroToscano
Redeploy aligned
8992807
@github-actions
Copy link

github-actions bot commented Mar 19, 2025 •
edited
Loading

Changes to gas cost

Generated at commit: 37adbfeb98cd5acacec0d15cf4137ea3fd78f947, compared to commit: 306f72d2c0f03f0107f55725c2ba5fa168f39fc4

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager batchesState
disabledVerifiers
isVerifierDisabled		 +4,688 ❌
+2,131 ❌
+1,609 ❌		 +649.31%
+556.40%
+129.03%
RegistryCoordinatorHarness blsApkRegistry +332 ❌ +116.90%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,319,208 (+3,087,974) batchesState
createNewTask
disableVerifier
disabledVerifiers
enableVerifier
isVerifierDisabled
receive
setDisabledVerifiers		 5,410 (+4,688)
77,706 (+21,623)
24,299 (+390)
2,514 (+2,131)
24,191 (+390)
2,856 (+2,275)
47,472 (+24,155)
24,250 (+451)		 +649.31%
+38.56%
+1.63%
+556.40%
+1.64%
+391.57%
+103.59%
+1.90%		 5,410 (+4,688)
78,004 (+1,943)
35,816 (+315)
2,514 (+2,131)
24,760 (+315)
2,856 (+1,609)
47,472 (+557)
35,176 (+370)		 +649.31%
+2.55%
+0.89%
+556.40%
+1.29%
+129.03%
+1.19%
+1.06%		 5,410 (+4,688)
77,922 (+1,681)
35,816 (+315)
2,514 (+2,131)
24,760 (+315)
2,856 (+2,275)
47,472 (+277)
35,176 (+370)		 +649.31%
+2.20%
+0.89%
+556.40%
+1.29%
+391.57%
+0.59%
+1.06%		 5,410 (+4,688)
78,756 (+1,762)
47,334 (+240)
2,514 (+2,131)
25,329 (+240)
2,856 (+275)
47,472 (+277)
46,103 (+290)		 +649.31%
+2.29%
+0.51%
+556.40%
+0.96%
+10.65%
+0.59%
+0.63%		 256 (0)
256 (0)
2 (0)
1 (0)
2 (0)
3 (0)
256 (0)
2 (0)
RegistryCoordinatorHarness 10,130,060 (+4,267,898) blsApkRegistry
initialize
stakeRegistry		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 6 (0)
6 (0)
6 (0)
Slasher 1,598,825 (+762,846) initialize 922 (+470) +103.98% 922 (+470) +103.98% 922 (+470) +103.98% 922 (+470) +103.98% 6 (0)
StakeRegistryHarness 5,139,510 (+2,005,505) delegation
initializeQuorum		 658 (+332)
146,200 (+3,117)		 +101.84%
+2.18%		 658 (+332)
165,996 (+3,117)		 +101.84%
+1.91%		 658 (+332)
166,100 (+3,117)		 +101.84%
+1.91%		 658 (+332)
166,100 (+3,117)		 +101.84%
+1.91%		 6 (0)
1,152 (0)
ProxyAdmin 757,646 (+329,348) upgrade
upgradeAndCall		 39,641 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,650 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,653 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,653 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 24 (0)
6 (0)
AVSDirectory 3,174,782 (+1,463,555) initialize 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 6 (0)
ServiceManagerMock 2,632,783 (+1,054,449) initialize 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 6 (0)
BLSApkRegistryHarness 3,124,237 (+1,317,862) initializeQuorum
setBLSPublicKey		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 1,152 (0)
6 (0)
TransparentUpgradeableProxy 897,999 (+341,241) fallback 1,544 (+477) +44.70% 48,066 (+774) +1.64% 8,110 (+477) +6.25% 120,000 (+885) +0.74% 30 (0)
IndexRegistry 1,707,557 (+637,897) initializeQuorum 45,592 (+528) +1.17% 45,592 (+528) +1.17% 45,592 (+528) +1.17% 45,592 (+528) +1.17% 1,152 (0)
StrategyManagerMock 2,401,372 (+1,154,891) setAddresses 89,742 (+597) +0.67% 89,742 (+597) +0.67% 89,742 (+597) +0.67% 89,742 (+597) +0.67% 6 (0)

@MauroToscano MauroToscano enabled auto-merge March 19, 2025 19:07
@MauroToscano MauroToscano added this pull request to the merge queue Mar 19, 2025
Merged via the queue into staging with commit 677f9a9 Mar 19, 2025
4 checks passed
@MauroToscano MauroToscano deleted the 1759-fixcontract-remove-reinitializers-from-contracts branch March 19, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

+1 more reviewer

@Oppen Oppen Oppen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@uri-99 uri-99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(contract): remove reinitializers from contracts

5 participants

@uri-99 @Oppen @JuArce @MauroToscano