Skip to content

fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 6 commits into from
Mar 18, 2025
Merged

fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol #1762

MauroToscano merged 6 commits into from
Mar 18, 2025

Conversation

@uri-99
Copy link
Contributor

@uri-99 uri-99 commented Jan 20, 2025 •
edited by JuArce
Loading

Remove deprecated verifyBatchInclusion

Description

We remove the old and deprecated verifyBatchInclusion function from AlignedLayerServiceManager.sol , to avoid user confusion.

How to Test

This PR is a removal of a deprecated function.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 self-assigned this Jan 20, 2025
@uri-99 uri-99 linked an issue Jan 20, 2025 that may be closed by this pull request
fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol #1757
Closed
@uri-99 uri-99 changed the base branch from testnet to staging January 20, 2025 18:27
@uri-99 uri-99 changed the title fix(contract): remove deprecated verifybatchinclusion from alignedlayerservicemanagersol fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol Jan 20, 2025
@uri-99 uri-99 mentioned this pull request Jan 22, 2025
Closed
18 tasks
JuArce
JuArce requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing to update the anvil state

examples/verify/src/VerifyBatchInclusionCaller.sol
Copy link
Collaborator

@JuArce JuArce Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing to udpdate the README with a new contract address for the example

JuArce added 2 commits March 18, 2025 18:18
@JuArce
Merge branch 'refs/heads/staging' into 1757-fixcontract-remove-deprec…
1ba5f77 
…ated-verifybatchinclusion-from-alignedlayerservicemanagersol

# Conflicts:
#	contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
@JuArce
fix: update anvil state
f71a6e4
@MauroToscano MauroToscano enabled auto-merge March 18, 2025 21:20
@github-actions
Copy link

github-actions bot commented Mar 18, 2025

Changes to gas cost

Generated at commit: 81c1bce59ab33afd8b58d4f09647e028692d0d39, compared to commit: 306f72d2c0f03f0107f55725c2ba5fa168f39fc4

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager batchesState
disabledVerifiers
isVerifierDisabled		 +4,710 ❌
+2,153 ❌
+1,609 ❌		 +652.35%
+562.14%
+129.03%
RegistryCoordinatorHarness blsApkRegistry +332 ❌ +116.90%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 8,464,710 (+3,233,476) batchesState
createNewTask
disableVerifier
disabledVerifiers
enableVerifier
isVerifierDisabled
receive
setDisabledVerifiers		 5,432 (+4,710)
57,696 (+1,613)
24,299 (+390)
2,536 (+2,153)
24,191 (+390)
2,856 (+2,275)
23,496 (+179)
24,272 (+473)		 +652.35%
+2.88%
+1.63%
+562.14%
+1.64%
+391.57%
+0.77%
+1.99%		 5,432 (+4,710)
77,585 (+1,524)
35,816 (+315)
2,536 (+2,153)
24,760 (+315)
2,856 (+1,609)
47,097 (+182)
35,198 (+392)		 +652.35%
+2.00%
+0.89%
+562.14%
+1.29%
+129.03%
+0.39%
+1.13%		 5,432 (+4,710)
77,812 (+1,571)
35,816 (+315)
2,536 (+2,153)
24,760 (+315)
2,856 (+2,275)
47,472 (+277)
35,198 (+392)		 +652.35%
+2.06%
+0.89%
+562.14%
+1.29%
+391.57%
+0.59%
+1.13%		 5,432 (+4,710)
78,607 (+1,613)
47,334 (+240)
2,536 (+2,153)
25,329 (+240)
2,856 (+275)
47,472 (+277)
46,125 (+312)		 +652.35%
+2.09%
+0.51%
+562.14%
+0.96%
+10.65%
+0.59%
+0.68%		 256 (0)
256 (0)
2 (0)
1 (0)
2 (0)
3 (0)
256 (0)
2 (0)
RegistryCoordinatorHarness 10,130,060 (+4,267,898) blsApkRegistry
initialize
stakeRegistry		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 616 (+332)
56,281,475 (+1,577,892)
682 (+332)		 +116.90%
+2.88%
+94.86%		 6 (0)
6 (0)
6 (0)
Slasher 1,598,825 (+762,846) initialize 922 (+470) +103.98% 922 (+470) +103.98% 922 (+470) +103.98% 922 (+470) +103.98% 6 (0)
StakeRegistryHarness 5,139,510 (+2,005,505) delegation
initializeQuorum		 658 (+332)
146,200 (+3,117)		 +101.84%
+2.18%		 658 (+332)
165,996 (+3,117)		 +101.84%
+1.91%		 658 (+332)
166,100 (+3,117)		 +101.84%
+1.91%		 658 (+332)
166,100 (+3,117)		 +101.84%
+1.91%		 6 (0)
1,152 (0)
ProxyAdmin 757,646 (+329,348) upgrade
upgradeAndCall		 39,641 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,650 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,653 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 39,653 (+845)
56,632,018 (+1,579,612)		 +2.18%
+2.87%		 24 (0)
6 (0)
AVSDirectory 3,174,782 (+1,463,555) initialize 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 100,637 (+2,514) +2.56% 6 (0)
ServiceManagerMock 2,632,783 (+1,054,449) initialize 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 73,362 (+1,409) +1.96% 6 (0)
BLSApkRegistryHarness 3,124,237 (+1,317,862) initializeQuorum
setBLSPublicKey		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 45,978 (+772)
90,107 (+740)		 +1.71%
+0.83%		 1,152 (0)
6 (0)
TransparentUpgradeableProxy 897,999 (+341,241) fallback 1,544 (+477) +44.70% 48,066 (+774) +1.64% 8,110 (+477) +6.25% 120,000 (+885) +0.74% 30 (0)
IndexRegistry 1,707,557 (+637,897) initializeQuorum 45,592 (+528) +1.17% 45,592 (+528) +1.17% 45,592 (+528) +1.17% 45,592 (+528) +1.17% 1,152 (0)
StrategyManagerMock 2,401,372 (+1,154,891) setAddresses 89,742 (+597) +0.67% 89,742 (+597) +0.67% 89,742 (+597) +0.67% 89,742 (+597) +0.67% 6 (0)

@MauroToscano MauroToscano added this pull request to the merge queue Mar 18, 2025
Merged via the queue into staging with commit 4dc0c96 Mar 18, 2025
4 checks passed
@MauroToscano MauroToscano deleted the 1757-fixcontract-remove-deprecated-verifybatchinclusion-from-alignedlayerservicemanagersol branch March 18, 2025 21:41
@JuArce JuArce mentioned this pull request Apr 25, 2025
Merged
13 tasks
MauroToscano added a commit that referenced this pull request Apr 28, 2025
@JuArce @MauroToscano
fix(contracts): revert #1762 verifyBatchInclusion function (#1892)
14f831f 
Co-authored-by: Mauro Toscano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

Assignees

@uri-99 uri-99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(contract): remove deprecated verifyBatchInclusion from AlignedLayerServiceManager.sol

4 participants

@uri-99 @MauroToscano @JuArce