Skip to content

Conversation

@PatStiles
Copy link
Contributor

@PatStiles PatStiles commented Jan 9, 2025

Display the number of proofs in a batch from the created task

Description

Currently the alert sender just sends the number of repetitions of sent proofs. This pr changes this to fetch the number of proof submitters in the batch from the proofSubmitters parameter of the createNewTask function call. This parameters contains the addresses of each submitted proof therefore the number of submitters corresponds to the number of proofs in the batch.

To Test:

  • start a local devnet
  • execute the alert script via ./alerts/sender_with_alert.sh ./alerts/.env.devnet
    You should observe that the correct number of proofs in a batch is displayed now and observe that if a second senders proofs are included in the batch the number of proofs are displayed. Adding additional task senders should increase the batch size.
16 proofs submitted and verified. We sent 16 proofs. Spent amount: 0.000171417922653 ETH ($ 0.57) [ http://localhost:3000/batches/0x0a8dd28a8e7a38151a22b3f04315d17be3a583fdc5fc925d085084b4c8732b27 ]

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@PatStiles PatStiles force-pushed the feat/add_batch_size_to_alert_sender branch 2 times, most recently from 413aada to c8887ea Compare January 10, 2025 15:29
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working locally for me.

Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, wip testing

@JuArce JuArce merged commit 422f6d4 into testnet Jan 14, 2025
1 check passed
@JuArce JuArce deleted the feat/add_batch_size_to_alert_sender branch January 14, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants