feat(cli): Add private-key to deposit to batcher #1724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianVentura
approved these changes
Jan 8, 2025
avilagaston9
approved these changes
Jan 9, 2025
Contributor
avilagaston9
left a comment
avilagaston9
left a comment
There was a problem hiding this comment.
Left a nit comment. Otherwise, LGTM!
uri-99
suggested changes
Jan 9, 2025
Contributor
uri-99
left a comment
uri-99
left a comment
There was a problem hiding this comment.
missing added to cli docs
PatStiles
force-pushed
the
feat/add_private_key_to_deposit_to_batcher
branch
from
13f1ac7 to
9835802
Compare
PatStiles
force-pushed
the
feat/add_private_key_to_deposit_to_batcher
branch
from
9835802 to
1c4e019
Compare
uri-99
reviewed
Jan 10, 2025
uri-99
approved these changes
Jan 10, 2025
MarcosNicolau
approved these changes
Jan 13, 2025
JuArce
requested changes
Jan 13, 2025
Collaborator
JuArce
left a comment
JuArce
left a comment
There was a problem hiding this comment.
There is missing # How to test section
JuArce
approved these changes
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add private-key to deposit to batcher
Description
Addresses the second item of #1568.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging