Skip to content

hotfix(explorer): Fix the proof price average #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuArce merged 3 commits into from
Jan 9, 2025
Merged

hotfix(explorer): Fix the proof price average #1717

JuArce merged 3 commits into from
Jan 9, 2025

Conversation

@JulianVentura
Copy link
Contributor

@JulianVentura JulianVentura commented Jan 7, 2025

Fix the proof price average

Description

This PR fixes the calculation of the proof price average.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JulianVentura JulianVentura linked an issue Jan 7, 2025 that may be closed by this pull request
fix(explorer): avg fee per price should be weighted for amt_of_proofs in batch #1714
Closed
@JulianVentura JulianVentura self-assigned this Jan 7, 2025
@JulianVentura JulianVentura marked this pull request as ready for review January 7, 2025 15:46
JuArce
JuArce requested changes Jan 7, 2025
View reviewed changes
@JulianVentura JulianVentura changed the title hotfix(explorer): Fix the proof price average hotfix(explorer): (WIP) Fix the proof price average Jan 8, 2025
@JulianVentura JulianVentura force-pushed the 1714-fixexplorer-avg-fee-per-price-should-be-weighted-for-amt_of_proofs-in-batch branch from 18c98b9 to 5a0f39f Compare January 8, 2025 20:12
@JulianVentura JulianVentura changed the title hotfix(explorer): (WIP) Fix the proof price average hotfix(explorer): Fix the proof price average Jan 8, 2025
@JuArce JuArce merged commit b396d02 into testnet Jan 9, 2025
1 check passed
@JuArce JuArce deleted the 1714-fixexplorer-avg-fee-per-price-should-be-weighted-for-amt_of_proofs-in-batch branch January 9, 2025 14:41
PatStiles pushed a commit that referenced this pull request Jan 9, 2025
@JulianVentura @JuArce @PatStiles
hotfix(explorer): Fix the proof price average (#1717)
8325d76 
Co-authored-by: Julian Ventura <[email protected]>
Co-authored-by: Julian Arce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

+2 more reviewers

@PatStiles PatStiles PatStiles approved these changes

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JulianVentura JulianVentura

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(explorer): avg fee per price should be weighted for amt_of_proofs in batch

6 participants

@JulianVentura @MauroToscano @PatStiles @uri-99 @JuArce