Skip to content

hotfix(explorer): Add endpoint to fetch last 24 hours number of proofs verified #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 5 commits into from
Jan 6, 2025
Merged

hotfix(explorer): Add endpoint to fetch last 24 hours number of proofs verified #1710

MauroToscano merged 5 commits into from
Jan 6, 2025

Conversation

@JulianVentura
Copy link
Contributor

@JulianVentura JulianVentura commented Jan 6, 2025 •
edited by JuArce
Loading

Add last 24 hours number of proofs verified endpoint

Description

We need access to the number of verified proofs on the last 24 hours, so we can provide that information on the Aligned web. This PR adds a new endpoint providing that information.

How to test

  1. Start a devnet, including the explorer
  2. Send a fixed amount of proofs on different batches, for instance 5 batches
  3. Visit /api/proofs_verified_last_24h and you should see the number of proofs verified in the last 24 hours.
  4. Verify that the provided value matches with the sent and verified proofs. For that, you can check in the explorer the amount of proofs sent (manually sum them all)

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JulianVentura JulianVentura marked this pull request as ready for review January 6, 2025 16:56
@avilagaston9 avilagaston9 changed the title feat(explorer): Add endpoint to fetch last 24 hours number of proofs verified hotfix(explorer): Add endpoint to fetch last 24 hours number of proofs verified Jan 6, 2025
uri-99
uri-99 suggested changes Jan 6, 2025
View reviewed changes
uri-99
uri-99 reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code working as expected

@MauroToscano MauroToscano merged commit e6a5de4 into testnet Jan 6, 2025
1 check passed
@MauroToscano MauroToscano deleted the feat/explorer-api-fetch-last-batch-number-of-proofs branch January 6, 2025 19:32
PatStiles pushed a commit that referenced this pull request Jan 9, 2025
@JulianVentura @avilagaston9
@MauroToscano @JuArce @PatStiles
hotfix(explorer): Add endpoint to fetch last 24 hours number of proof…
23d4d6d 
…s verified (#1710)

Co-authored-by: Julian Ventura <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
Co-authored-by: Mauro Toscano <[email protected]>
Co-authored-by: JuArce <[email protected]>
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@JulianVentura @avilagaston9
@MauroToscano @JuArce @PatStiles
hotfix(explorer): Add endpoint to fetch last 24 hours number of proof…
a7ae4d3 
…s verified (#1710)

Co-authored-by: Julian Ventura <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
Co-authored-by: Mauro Toscano <[email protected]>
Co-authored-by: JuArce <[email protected]>
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@JulianVentura @avilagaston9
@MauroToscano @JuArce @PatStiles
hotfix(explorer): Add endpoint to fetch last 24 hours number of proof…
a0e1052 
…s verified (#1710)

Co-authored-by: Julian Ventura <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
Co-authored-by: Mauro Toscano <[email protected]>
Co-authored-by: JuArce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

+1 more reviewer

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JulianVentura JulianVentura

@avilagaston9 avilagaston9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JulianVentura @MauroToscano @uri-99 @JuArce @avilagaston9