Skip to content

Conversation

@uri-99
Copy link
Contributor

@uri-99 uri-99 commented Jan 2, 2025

wei_to_usd that takes amount of significant figures

Description

We were always using wei_to_usd that takes amount of decimals.
This new function takes amount of significant figures, which is more appropriate for some use cases where the numbers vary in decimal places

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 changed the base branch from testnet to explorer-new-version January 2, 2025 17:03
@uri-99 uri-99 merged commit 4368d75 into explorer-new-version Jan 2, 2025
9 checks passed
@uri-99 uri-99 deleted the fix-wei-usd-read-significant-figures branch January 2, 2025 17:10
@uri-99 uri-99 mentioned this pull request Jan 2, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants