Skip to content

fix(docs): batcher and explorer urls #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuArce merged 9 commits into from
Dec 30, 2024
Merged

fix(docs): batcher and explorer urls #1688

JuArce merged 9 commits into from
Dec 30, 2024

Conversation

@avilagaston9
Copy link
Contributor

@avilagaston9 avilagaston9 commented Dec 30, 2024

Fix Batcher and Explorer urls

Description

  • Adds Explorer url to docs (mainnet and Holesky).
  • Updates batcher url for mainnet.

Type of change

  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@avilagaston9 avilagaston9 marked this pull request as ready for review December 30, 2024 16:19
@avilagaston9 avilagaston9 self-assigned this Dec 30, 2024
JuArce
JuArce requested changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use holesky on the predefined examples. It could lead to users sending funds in mainnet by error

@avilagaston9
Copy link
Contributor Author

avilagaston9 commented Dec 30, 2024

Use holesky on the predefined examples. It could lead to users sending funds in mainnet by error
@JuArce

Addressed in bc1e43f!

uri-99
uri-99 suggested changes Dec 30, 2024
View reviewed changes
@JuArce JuArce merged commit 1ebb705 into testnet Dec 30, 2024
2 checks passed
@JuArce JuArce deleted the fix-doc-urls branch December 30, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

+2 more reviewers

@Oppen Oppen Oppen approved these changes

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@avilagaston9 avilagaston9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avilagaston9 @Oppen @uri-99 @JuArce