Skip to content

fix(ci): foundryup install flag #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuArce merged 1 commit into from
Dec 23, 2024
Merged

fix(ci): foundryup install flag #1678

JuArce merged 1 commit into from
Dec 23, 2024

Conversation

@avilagaston9
Copy link
Contributor

@avilagaston9 avilagaston9 commented Dec 23, 2024 •
edited
Loading

Update foundryup flag to install specific version

Description

This PR in the foundry repo changed the -v, --version flag to -i to install a specific version: foundry-rs/foundry#9551

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@avilagaston9 avilagaston9 changed the title fix: foundry inatall flag fix: foundry install flag Dec 23, 2024
@avilagaston9 avilagaston9 changed the title fix: foundry install flag fix: foundryup install flag Dec 23, 2024
@avilagaston9 avilagaston9 changed the title fix: foundryup install flag fix(ci): foundryup install flag Dec 23, 2024
@avilagaston9 avilagaston9 self-assigned this Dec 23, 2024
@avilagaston9 avilagaston9 marked this pull request as ready for review December 23, 2024 13:23
JuArce
JuArce requested changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@JuArce JuArce left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point to testnet as hotfix

@avilagaston9 avilagaston9 changed the base branch from staging to testnet December 23, 2024 13:45
@JuArce JuArce merged commit 5184bd0 into testnet Dec 23, 2024
3 checks passed
@JuArce JuArce deleted the fix-foundry-ci branch December 23, 2024 15:04
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@avilagaston9 @PatStiles
fix(ci): foundryup install flag (#1678)
5f5679d
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@avilagaston9 @PatStiles
fix(ci): foundryup install flag (#1678)
6351012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

+2 more reviewers

@uri-99 uri-99 uri-99 approved these changes

@JulianVentura JulianVentura JulianVentura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@avilagaston9 avilagaston9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@avilagaston9 @uri-99 @JulianVentura @JuArce @MarcosNicolau