Skip to content

Conversation

@avilagaston9
Copy link
Contributor

@avilagaston9 avilagaston9 commented Dec 20, 2024

Fix Accumulated Aggregator Cost Panels

Description

This PR addresses a couple of issues in the Aggregator cost panels.

  • Separates the panels into historical and time ranges.
  • Uses the receipt values instead of the raw transaction ones (we were overestimating the costs since not all of the gas limit is consumed during a transaction execution).
  • Adds a target to clean the metrics db.

image

Type of change

  • Bug fix

How to test

  1. Start all Aligned components and start sending proofs
  2. Start Grafana and go to localhost:3000:
make run_metrics
  1. Check the new panels and play with the time range selector on the top-right corner:
    image
  2. Use the new target to clean the db:
make metrics_clean_db

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@avilagaston9 avilagaston9 marked this pull request as ready for review December 20, 2024 17:38
@avilagaston9 avilagaston9 self-assigned this Dec 20, 2024
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@JuArce JuArce enabled auto-merge January 2, 2025 15:28
@JuArce JuArce added this pull request to the merge queue Jan 2, 2025
Merged via the queue into staging with commit b01a2d3 Jan 2, 2025
3 checks passed
@JuArce JuArce deleted the fix-aggregator-costs-panels branch January 2, 2025 16:00
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants