-
Notifications
You must be signed in to change notification settings - Fork 391
feat: add batcher accumulated cost metric #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JulianVentura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are not converting to gwei properly, I left you a comment pointing were I think the problem is.
Other than that, everything seems to be working fine.
JulianVentura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, but the cost measurement has some error close to 0.7%, probably due to the usage of floating point.
Anyways, I think this is low priority so we can merge it.
Add Batcher Cost Metric
Description
This PR adds four panels showing the accumulated spending costs by the Batcher for creating and canceling tasks.
How to test
To easily send a cancel transaction, you can go to
batcher/aligned-batcher/src/retry/batcher_retryables.rs:165and edit the code to return an error:Type of change
Checklist
testnet, everything else tostaging