Skip to content

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Dec 18, 2024

Pin zap-pretty version in Dockerfile

Description

As in the Makefile, latest is broken, and breaks the build.
Longer term we should probably either write a dumb script called by both or simply call make inside the Dockerfile.

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce merged commit 2fb47c1 into testnet Dec 19, 2024
1 check passed
@JuArce JuArce deleted the hotfix/docker_base_pinned_deps branch December 19, 2024 20:01
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants