Skip to content

chore(claim_contracts): add security contact to airdrop contract #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuArce merged 3 commits into from
Dec 18, 2024
Merged

chore(claim_contracts): add security contact to airdrop contract #1649

JuArce merged 3 commits into from
Dec 18, 2024

Conversation

@ManuelBilbao
Copy link
Contributor

@ManuelBilbao ManuelBilbao commented Dec 18, 2024

Add security contact to airdrop contract

Description

This PR adds the @custom:security-contact NatSpec comment to the airdrop contract as recommended by OpenZeppelin.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@JuArce JuArce merged commit 6d79fc7 into yetanotherco:testnet Dec 18, 2024
1 check passed
@ilitteri
Copy link
Contributor

ilitteri commented Dec 20, 2024

Fixes issue:

  • L-09

PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@ManuelBilbao @ilitteri
@jrchatruc @PatStiles
chore(claim_contracts): add security contact to airdrop contract (#1649)
fb86574 
Co-authored-by: Ivan Litteri <[email protected]>
Co-authored-by: Javier Rodríguez Chatruc <[email protected]>
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@ManuelBilbao @ilitteri
@jrchatruc @PatStiles
chore(claim_contracts): add security contact to airdrop contract (#1649)
4336756 
Co-authored-by: Ivan Litteri <[email protected]>
Co-authored-by: Javier Rodríguez Chatruc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

@ilitteri ilitteri ilitteri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ManuelBilbao @ilitteri @MegaRedHand @jrchatruc @JuArce