Skip to content

hotfix: zap-pretty version in make deps #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuArce merged 1 commit into from
Dec 18, 2024
Merged

hotfix: zap-pretty version in make deps #1647

JuArce merged 1 commit into from
Dec 18, 2024

Conversation

@uri-99
Copy link
Contributor

@uri-99 uri-99 commented Dec 18, 2024 •
edited
Loading

Pin zap-pretty version in make deps

Description

zep-pretty version needs to be pinned

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 self-assigned this Dec 18, 2024
Oppen
Oppen approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installs the right version here.

@JuArce JuArce merged commit 795013a into testnet Dec 18, 2024
1 check passed
@JuArce JuArce deleted the hotfix-operator-make-go-deps branch December 18, 2024 20:51
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@uri-99 @PatStiles
hotfix: zap-pretty version in make deps (#1647)
4b880ce
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@uri-99 @PatStiles
hotfix: zap-pretty version in make deps (#1647)
5cd7171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

+3 more reviewers

@Oppen Oppen Oppen approved these changes

@PatStiles PatStiles PatStiles approved these changes

@avilagaston9 avilagaston9 avilagaston9 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@uri-99 uri-99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uri-99 @Oppen @PatStiles @JuArce @avilagaston9