chore(claim): move state update before call #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
approved these changes
Dec 18, 2024
jrchatruc
approved these changes
Dec 18, 2024
ManuelBilbao
approved these changes
Dec 18, 2024
Contributor
|
Fixes Least Authority Suggestion 1 |
PatStiles
pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Javier Rodríguez Chatruc <[email protected]> Co-authored-by: Julian Arce <[email protected]>
PatStiles
pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Javier Rodríguez Chatruc <[email protected]> Co-authored-by: Julian Arce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move state update before call
Description
If the
nonReentrantmodifier is removed, theclaimfunction is prone to the reentrancy bug, by moving the state update above the transfer call we add redundancy to protect against the bug.Type of change
Please delete options that are not relevant.