Skip to content

feat(explorer): batch-size chart #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uri-99 merged 35 commits into from
Dec 23, 2024
Merged

feat(explorer): batch-size chart #1641

uri-99 merged 35 commits into from
Dec 23, 2024

Conversation

@PatStiles
Copy link
Contributor

@PatStiles PatStiles commented Dec 18, 2024

Add batch-size chart to the explorer

Description

Based off #1635 (shout out @MarcosNicolau) adds a chart to the explorer that shows the batch size of batches over the last 100 blocks.

To Test

Start a local devnet.
Run the explorer.
Send proofs at various rates and observe the batch size increase or decrease.

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@PatStiles PatStiles changed the base branch from staging to feat/explorer-cost-per-proof-chart December 18, 2024 15:17
@PatStiles PatStiles force-pushed the feat/explorer-batch-size-chart branch from f2898ab to ec09e21 Compare December 18, 2024 18:07
@PatStiles PatStiles force-pushed the feat/explorer-batch-size-chart branch from ec09e21 to 20acafd Compare December 18, 2024 18:38
uri-99
uri-99 suggested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr will need to pull changes from #1635 when its ready

@uri-99 uri-99 mentioned this pull request Dec 19, 2024
Merged
17 tasks
@MarcosNicolau MarcosNicolau requested a review from uri-99 December 20, 2024 12:53
@uri-99 uri-99 force-pushed the feat/explorer-cost-per-proof-chart branch from d431fc7 to b7f1c89 Compare December 21, 2024 00:39
Base automatically changed from feat/explorer-cost-per-proof-chart to explorer-new-version December 23, 2024 18:50
@uri-99 uri-99 merged commit 76954ee into explorer-new-version Dec 23, 2024
1 check passed
@uri-99 uri-99 deleted the feat/explorer-batch-size-chart branch December 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Oppen Oppen Oppen approved these changes

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PatStiles @Oppen @uri-99 @MarcosNicolau