Skip to content

Rename ERC20 constants, add security contact to ERC20, add a small command in Makefile #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 5 commits into from
Dec 18, 2024
Merged

Rename ERC20 constants, add security contact to ERC20, add a small command in Makefile #1639

MauroToscano merged 5 commits into from
Dec 18, 2024

Conversation

@ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Dec 18, 2024

TITLE

Description

Description of the pull request changes and motivation.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@ilitteri ilitteri self-assigned this Dec 18, 2024
@MauroToscano MauroToscano merged commit e469e38 into testnet Dec 18, 2024
3 checks passed
@MauroToscano MauroToscano deleted the last_erc20_fixes branch December 18, 2024 04:48
@ilitteri
Copy link
Contributor Author

ilitteri commented Dec 20, 2024

Fixes issue:

  • L-09

@MauroToscano MauroToscano changed the title ERC20 fixes Rename ERC20 constants, add security contact to ERC20, add a small command in Makefile Dec 22, 2024
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@ilitteri @PatStiles
ERC20 fixes (#1639)
f65d458
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@ilitteri @PatStiles
ERC20 fixes (#1639)
e53a310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@JuArce JuArce JuArce approved these changes

+2 more reviewers

@Arkenan Arkenan Arkenan approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ilitteri ilitteri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ilitteri @Arkenan @MauroToscano @MegaRedHand @JuArce