Skip to content

Add more correction of OpenZeppelin/creed found issues #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilitteri merged 2 commits into from
Dec 18, 2024
Merged

Add more correction of OpenZeppelin/creed found issues #1636

ilitteri merged 2 commits into from
Dec 18, 2024

Conversation

@ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Dec 17, 2024

No description provided.

@ilitteri ilitteri self-assigned this Dec 17, 2024
MegaRedHand
MegaRedHand approved these changes Dec 17, 2024
View reviewed changes
@ilitteri ilitteri merged commit ae8a0aa into testnet Dec 18, 2024
3 checks passed
@ilitteri ilitteri deleted the openzeppelin_audit_changes branch December 18, 2024 02:10
@ilitteri
Copy link
Contributor Author

ilitteri commented Dec 20, 2024 •
edited
Loading

Fixes OpenZeppelin issues:

  • L-02
  • L-03
  • N-03
  • N-04
  • N-05
  • N-07
  • N-08
  • N-10
  • N-11
  • N-13

@ilitteri
Copy link
Contributor Author

ilitteri commented Dec 20, 2024

Fixes Creed issues:

  • Incorrect Usage of ReentrancyGuard instead of ReentrancyGuardUpgradeable
  • Redundant Modifiers in pause and unpause Functions
  • Missing Events in State-Changing Functions
  • Simplify Initialization of ClaimableAirdrop

@MauroToscano MauroToscano changed the title Add OpenZeppelin audit changes Add more correction of OpenZeppelin found issues Dec 22, 2024
@MauroToscano MauroToscano changed the title Add more correction of OpenZeppelin found issues Add more correction of OpenZeppelin/creed found issues Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@juanbono juanbono juanbono approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ilitteri ilitteri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ilitteri @juanbono @MegaRedHand @jrchatruc