Skip to content

feat(explorer): cost per proof chart #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uri-99 merged 31 commits into from
Dec 23, 2024
Merged

feat(explorer): cost per proof chart #1635

uri-99 merged 31 commits into from
Dec 23, 2024

Conversation

@MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Dec 17, 2024 •
edited
Loading

Description

  • Integrate chart.js library and create line_chart component.
  • Fetch fee_per_proof for the last n batches
  • Add a new module in home that shows the cost per proof of the last 100 batches
Screenshot 2024-12-19 at 2 48 35 PM

Testing

  • Start a local devnet.
  • Run the explorer.
  • Send proofs and see how the graph starts to fill.

Type of change

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau MarcosNicolau marked this pull request as ready for review December 18, 2024 01:47
@PatStiles PatStiles mentioned this pull request Dec 18, 2024
Merged
14 tasks
uri-99
uri-99 suggested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this tooltip, we could add more info to it.
amount of proofs, merkle_root, gas per proof and gas_price.
Also "block number" could be better with "submition block number" for more clarity
image

uri-99
uri-99 reviewed Dec 18, 2024
View reviewed changes
uri-99
uri-99 reviewed Dec 18, 2024
View reviewed changes
@MarcosNicolau MarcosNicolau self-assigned this Dec 18, 2024
@uri-99 uri-99 mentioned this pull request Dec 19, 2024
Merged
17 tasks
@uri-99 uri-99 changed the base branch from staging to explorer-new-version December 20, 2024 17:11
uri-99
uri-99 suggested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X axis is not proportional, all proofs are equidistant even though they may have different time between them

@MarcosNicolau MarcosNicolau requested a review from uri-99 December 20, 2024 17:59
@uri-99 uri-99 force-pushed the feat/explorer-cost-per-proof-chart branch 3 times, most recently from d431fc7 to b7f1c89 Compare December 21, 2024 00:39
uri-99
uri-99 reviewed Dec 23, 2024
View reviewed changes
@uri-99 uri-99 merged commit db4247c into explorer-new-version Dec 23, 2024
1 check passed
@uri-99 uri-99 deleted the feat/explorer-cost-per-proof-chart branch December 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@PatStiles PatStiles PatStiles approved these changes

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarcosNicolau MarcosNicolau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcosNicolau @PatStiles @uri-99