-
Notifications
You must be signed in to change notification settings - Fork 391
feat: task sender with slack updates and pager duty alerts #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JuArce
merged 27 commits into
testnet
from
1552-feat-task-sender-that-sends-alerts-to-pager-duty-on-failed-tasks-v2
Dec 19, 2024
Merged
feat: task sender with slack updates and pager duty alerts #1633
JuArce
merged 27 commits into
testnet
from
1552-feat-task-sender-that-sends-alerts-to-pager-duty-on-failed-tasks-v2
Dec 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: paths feat: add repetitions as parameter
chore: disable alerts
…o-pager-duty-on-failed-tasks
chore: use pk
feat: use nonce to generate proof
uri-99
suggested changes
Dec 17, 2024
JuArce
requested changes
Dec 17, 2024
Contributor
Author
uri-99
approved these changes
Dec 18, 2024
PatStiles
approved these changes
Dec 18, 2024
JuArce
requested changes
Dec 18, 2024
JuArce
requested changes
Dec 18, 2024
…o-pager-duty-on-failed-tasks-v2
JuArce
approved these changes
Dec 19, 2024
This was referenced Dec 19, 2024
PatStiles
pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: JuArce <[email protected]> Co-authored-by: Julian Ventura <[email protected]> Co-authored-by: Urix <[email protected]>
PatStiles
pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: JuArce <[email protected]> Co-authored-by: Julian Ventura <[email protected]> Co-authored-by: Urix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify how spent amount is calculated on task sender
Description
We have the task sender configured to send proofs periodically. After a new batch of proofs is verified, a slack message is sent notifying the cost of this submission and verification. The reported cost is associated with the
Fee per proofvariable, which is alright for the users, but not in this case. We just want to know how much did we spend only by creating the task and responding to it, without any fee to the batcher. This PR accomplishes that, by fetching the transaction receipts and calculating the exact fees.At the same time, some environment variables were added so it's easy to test this feature on different environments
How to test
send_slack_messagefunction onsender_with_alert.shwith the following:.envfile underalertsdirectory, using.env.exampleas a template./alerts/sender_with_alert.sh ./alerts/.envfee_per_proof * number_of_proofs, which you can see on the explorermax_batch_proof_qtyvariable under thetry_build_batchfunction on the batcher, so that the amount of proofs sent is split between two batches.max_batch_proof_qty, so the second batch doesn't have the same merkle root as the first one. For example,max_batch_proof_qty=7,repetitions=12.How to calculate by hand
gasUsedandeffectiveGasPriceType of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging