Skip to content

feat(explorer): mark pending batches in red after 5 minutes #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uri-99 merged 7 commits into from
Dec 19, 2024
Merged

feat(explorer): mark pending batches in red after 5 minutes #1624

uri-99 merged 7 commits into from
Dec 19, 2024

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Dec 16, 2024 •
edited by MarcosNicolau
Loading

Description

Marks pending batches in red after 5 minutes

Testing

  1. Start a local devnet
  2. Run the explorer
  3. Kill operators so that batches don't reach quorum
  4. Send proofs
  5. Verify that after 5min it goes red.

Type of change

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@Oppen Oppen marked this pull request as ready for review December 16, 2024 19:38
MarcosNicolau
MarcosNicolau approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I updated your comment with a testing section 👍

@Oppen
Copy link
Contributor Author

Oppen commented Dec 18, 2024

Nice, I updated your comment with a testing section 👍

Thanks! Forgot about it, just promoted the draft. I'll update myself tomorrow for the other one.

Oppen
Oppen commented Dec 18, 2024
View reviewed changes
@Oppen Oppen marked this pull request as draft December 18, 2024 15:07
uri-99
uri-99 reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

uri-99
uri-99 suggested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Oppen added 2 commits December 18, 2024 16:50
@Oppen
Revert "mark invalid on nil batch"
7e8ee60 
This reverts commit 2eddfd3.

This should be handled separately
@Oppen
Revert "send broadcast for unverified batches"
e9ef860 
This reverts commit e708808.

This will be handled separately, as it seems to be a separate issue
@Oppen Oppen marked this pull request as ready for review December 18, 2024 19:51
@Oppen Oppen mentioned this pull request Dec 18, 2024
Closed
@uri-99 uri-99 changed the base branch from staging to explorer-new-version December 19, 2024 15:36
@uri-99 uri-99 mentioned this pull request Dec 19, 2024
Merged
17 tasks
@uri-99 uri-99 merged commit 98623fc into explorer-new-version Dec 19, 2024
1 check passed
@uri-99 uri-99 deleted the feat/explorer_pending_color branch December 19, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

+2 more reviewers

@PatStiles PatStiles PatStiles approved these changes

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Oppen @PatStiles @uri-99 @MarcosNicolau