Skip to content

Corrected errors in deployment scripts, added multiple fixes from audits to contracts #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilitteri merged 28 commits into from
Dec 17, 2024
Merged

Corrected errors in deployment scripts, added multiple fixes from audits to contracts #1623

ilitteri merged 28 commits into from
Dec 17, 2024

Conversation

@jrchatruc
Copy link
Contributor

@jrchatruc jrchatruc commented Dec 16, 2024 •
edited by MauroToscano
Loading

Corrected errors in deployment scripts, added multiple fixes from audits to contracts

This PR corrects erros in the deployment scripts. Additionally, it addersses the following issues with the contracts:

  • TOTAL_SUPPLY constant is removed since it's redundant
  • Solidity version was outdated
  • Pragma versions where not fixed
  • Missing docstrings were added
  • TokenClaimed event parameters were documented

@jrchatruc jrchatruc changed the title [WIP] Fix proxy admin deployment in script Fix proxy admin deployment in script Dec 16, 2024
MegaRedHand
MegaRedHand approved these changes Dec 17, 2024
View reviewed changes
@ilitteri ilitteri merged commit c6ef331 into testnet Dec 17, 2024
1 check passed
@ilitteri ilitteri deleted the fix-script branch December 17, 2024 21:11
@ilitteri
Copy link
Contributor

ilitteri commented Dec 20, 2024 •
edited
Loading

Fixes OpenZeppelin issues:

  • L-01
  • L-04
  • L-05
  • L-06
  • N-012

@ilitteri
Copy link
Contributor

ilitteri commented Dec 20, 2024

Fixes Least Authority Suggestion 2

@MauroToscano MauroToscano changed the title Fix proxy admin deployment in script Corrected errors in deployment scripts, added multiple fixes from audits to contracts Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@ilitteri ilitteri ilitteri approved these changes

@juanbono juanbono juanbono approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jrchatruc @ilitteri @juanbono @MegaRedHand