Skip to content

feat(explorer): selector to switch network #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uri-99 merged 5 commits into from
Dec 19, 2024
Merged

feat(explorer): selector to switch network #1622

uri-99 merged 5 commits into from
Dec 19, 2024

Conversation

@MarcosNicolau
Copy link
Member

@MarcosNicolau MarcosNicolau commented Dec 16, 2024 •
edited
Loading

Description

Adds a selector in the explorer nav to switch the network.

Testing

  • Run the explorer locally and you should see the new selector:

large screens:
image

smalls screens:
image

Type of change

Type of change

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@MarcosNicolau MarcosNicolau changed the title feat(explorer): selector for the network feat(explorer): selector to switch network Dec 16, 2024
uri-99
uri-99 suggested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should go to staging

@MarcosNicolau MarcosNicolau changed the base branch from testnet to staging December 16, 2024 20:01
@uri-99
Copy link
Contributor

uri-99 commented Dec 16, 2024

The many file changes should go away when #1625 is merged

@MarcosNicolau MarcosNicolau self-assigned this Dec 18, 2024
Oppen
Oppen approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my machine. It's a little odd that because it works by redirecting to the other domains the UI itself changes. I would have expected as user that only the data it showed would change.

@MarcosNicolau
Copy link
Member Author

MarcosNicolau commented Dec 18, 2024

It works on my machine. It's a little odd that because it works by redirecting to the other domains the UI itself changes. I would have expected as user that only the data it showed would change.

It also seemed odd to me at first, but if you check sites like etherscan they do the same.

@uri-99 uri-99 changed the base branch from staging to explorer-new-version December 19, 2024 15:39
@uri-99 uri-99 mentioned this pull request Dec 19, 2024
Merged
17 tasks
@uri-99 uri-99 merged commit a8a489c into explorer-new-version Dec 19, 2024
1 check passed
@uri-99 uri-99 deleted the feat/explorer-network-selector branch December 19, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Oppen Oppen Oppen approved these changes

@PatStiles PatStiles PatStiles approved these changes

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarcosNicolau MarcosNicolau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MarcosNicolau @uri-99 @Oppen @PatStiles