Skip to content

fix: zkquiz proof submitions #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MauroToscano merged 12 commits into from
Dec 13, 2024
Merged

fix: zkquiz proof submitions #1597

MauroToscano merged 12 commits into from
Dec 13, 2024

Conversation

@uri-99
Copy link
Contributor

@uri-99 uri-99 commented Dec 9, 2024 •
edited
Loading

Fix ZKQuiz proof submitions

Description

ZKQuiz seemed broken because it was failing to receive messages from the Batcher. It was discovered this was because Batcher was cutting the connection with the timeout, because it was taking longer than 5 seconds to receive the proof. This makes sense because the ZKQuiz proof is 5 times bigger than the fibonnacci proof.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 changed the title Test zkquiz batcher fix: zkquiz proof submitions Dec 10, 2024
@uri-99 uri-99 marked this pull request as ready for review December 10, 2024 14:08
MarcosNicolau
MarcosNicolau approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@MarcosNicolau MarcosNicolau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested zkquiz locally and it indeed works with 30 secs.

@PatStiles PatStiles mentioned this pull request Dec 10, 2024
Open
@PatStiles
Copy link
Contributor

PatStiles commented Dec 10, 2024

I created the following up issues:

@MauroToscano MauroToscano merged commit 062eeb9 into staging Dec 13, 2024
3 checks passed
@MauroToscano MauroToscano deleted the test-zkquiz-batcher branch December 13, 2024 17:09
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@uri-99 @PatStiles
fix: zkquiz proof submitions (#1597)
d180bcd
PatStiles pushed a commit that referenced this pull request Jan 10, 2025
@uri-99 @PatStiles
fix: zkquiz proof submitions (#1597)
7cd0b2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@MarcosNicolau MarcosNicolau MarcosNicolau approved these changes

+1 more reviewer

@PatStiles PatStiles PatStiles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PatStiles PatStiles

@uri-99 uri-99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@uri-99 @PatStiles @MauroToscano @MarcosNicolau