feat(sdk): some SDK improvements #1568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uri-99
reviewed
Dec 4, 2024
uri-99
reviewed
Dec 4, 2024
uri-99
reviewed
Dec 4, 2024
uri-99
reviewed
Dec 4, 2024
uri-99
reviewed
Dec 4, 2024
uri-99
reviewed
Dec 4, 2024
uri-99
reviewed
Dec 4, 2024
Member
uri-99
changed the title
MarcosNicolau
changed the title
uri-99
suggested changes
Dec 5, 2024
Contributor
uri-99
left a comment
uri-99
left a comment
There was a problem hiding this comment.
missing remove batcher-url from rust task sender.
uri-99
approved these changes
Dec 5, 2024
Oppen
approved these changes
Dec 18, 2024
uri-99
changed the title
JulianVentura
approved these changes
Jan 2, 2025
Contributor
JulianVentura
left a comment
JulianVentura
left a comment
There was a problem hiding this comment.
Works as expected!
There are some docs conflicts
avilagaston9
reviewed
Jan 6, 2025
Comment on lines
+472
to
+475
| if private_key.is_some() { | ||
| error!("Conflicting inputs detected: Both a keystore and a private key were provided. Provide only one option to proceed."); | ||
| return Ok(()); | ||
| } |
Contributor
There was a problem hiding this comment.
MauroToscano
requested changes
Jan 6, 2025
Contributor
MauroToscano
left a comment
MauroToscano
left a comment
There was a problem hiding this comment.
This PR should be splitted in different PRs. Also, default network params is fine, but we should have a way to change the batcher url manually, let's re review this over the following days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK Changes
Description
Makes some changes to sdk:
batcher_urlfrom Network paramater.--private_keyflag to DepositToBatcherType of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging