refactor: move createTask simulation before s3 upload
#1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uri-99
reviewed
Dec 4, 2024
uri-99
reviewed
Dec 4, 2024
Contributor
uri-99
left a comment
uri-99
left a comment
There was a problem hiding this comment.
code looks good, need to test
PatStiles
approved these changes
Dec 5, 2024
avilagaston9
approved these changes
Dec 5, 2024
Contributor
avilagaston9
left a comment
avilagaston9
left a comment
There was a problem hiding this comment.
Works in my machine!
JulianVentura
approved these changes
Dec 5, 2024
Contributor
JulianVentura
left a comment
JulianVentura
left a comment
There was a problem hiding this comment.
Code looks fine and worked as expected locally
uri-99
approved these changes
Dec 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Uriel Mihura <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
JuArce
deleted the
1524-fixbatcher-createtask-simulation-should-be-executed-before-sending-batch-to-s3
branch
PatStiles
pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Uriel Mihura <[email protected]>
PatStiles
pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Uriel Mihura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the
createNewTasksimulation to run before uploading the batch toS3.Testing
Run a local
devnetand make it revert by:batchMerkleRootBatcherPaymentServicecontract to trigger a revertYou should see that the batch isn't uploaded to
s3when the simulation fails.Type of change
Checklist