fix(telemetry): remove sensitive data exposure #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uri-99
reviewed
Dec 3, 2024
Contributor
uri-99
left a comment
uri-99
left a comment
There was a problem hiding this comment.
I'm missing the information of version and rpc, but may be a local issue
Contributor
|
Ran locally and saw the described information. |
PatStiles
approved these changes
Dec 5, 2024
JuArce
approved these changes
Dec 5, 2024
Contributor
This may happen if the operator is started before the telemetry service is on, since said information is provided at operator startup on |
JulianVentura
approved these changes
Dec 5, 2024
Contributor
JulianVentura
left a comment
JulianVentura
left a comment
There was a problem hiding this comment.
Code looks good and it worked as expected locally
PatStiles
pushed a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Julian Arce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry: remove sensitive data exposure
Description
Changes the
/versionsendpoint to only expose the following fields of the operator:How to Test
Go to
localhost:4001/versionsand check that the displayed data is the expected.Also check the endpoint for that specific operator in
localhost:4001/versions/{operator_address}.Finally, check that
localhost:4001/api/operatorsandlocalhost:4001/api/operators/{operator_address}keeps displaying all operator data, not just the public.Note
The version may appear with a
nullvalue. This is because theversionvariable in the operator is set in compile time and we are not running the operator compiled binary.Type of change
Checklist
testnet, everything else tostaging